feat: more small messenger-server improvements (#257)

* feat(common): transaction errors can be used as std::error::Error

* refactor(common): PendingTransaction uses a lifetime

This connects the lifetime of the pending transaction to the lifetime of the prism client reference it contains.

* feat(client): expose CryptoAlgorithm

* feat(keys): use compressed representation when serializing verifying keys

* chore: incorporate changes in zkvm elf

Author: jns-ps

crates/client/src/lib.rs

@@ -10,7 +10,7 @@ pub use prism_common::{
     operation::{ServiceChallenge, ServiceChallengeInput, SignatureBundle},
     transaction::{Transaction, TransactionError, UnsignedTransaction},
 };
-pub use prism_keys::{Signature, SigningKey, VerifyingKey};
+pub use prism_keys::{CryptoAlgorithm, Signature, SigningKey, VerifyingKey};
 pub use prism_serde::binary;
 
 #[cfg(feature = "mockall")]

crates/common/src/api/mock.rs

@@ -26,7 +26,7 @@ impl MockPrismPendingTransaction {
 }
 
 #[async_trait]
-impl PendingTransaction for MockPrismPendingTransaction {
+impl PendingTransaction<'_> for MockPrismPendingTransaction {
     type Timer = MockPrismTimer;
 
     async fn wait_with_interval(&self, _: Duration) -> Result<Account, PrismApiError> {

crates/common/src/api/mod.rs

@@ -184,7 +184,7 @@ pub trait PrismApiTimer {
 const DEFAULT_POLLING_INTERVAL: Duration = Duration::from_secs(5);
 
 #[async_trait]
-pub trait PendingTransaction
+pub trait PendingTransaction<'a>
 where
     Self: Send + Sync,
 {
@@ -215,7 +215,7 @@ where
 }
 
 #[async_trait]
-impl<P> PendingTransaction for PendingTransactionImpl<'_, P>
+impl<'a, P> PendingTransaction<'a> for PendingTransactionImpl<'a, P>
 where
     P: PrismApi,
 {

crates/common/src/api/noop.rs

@@ -16,7 +16,7 @@ impl PrismApiTimer for NoopTimer {
 pub struct NoopPendingTransaction;
 
 #[async_trait]
-impl PendingTransaction for NoopPendingTransaction {
+impl PendingTransaction<'_> for NoopPendingTransaction {
     type Timer = NoopTimer;
 
     async fn wait_with_interval(&self, _: Duration) -> Result<Account, PrismApiError> {

crates/common/src/builder.rs

@@ -367,7 +367,7 @@ where
 
     pub async fn send(
         self,
-    ) -> Result<impl PendingTransaction<Timer = P::Timer> + 'a, PrismApiError> {
+    ) -> Result<impl PendingTransaction<'a, Timer = P::Timer>, PrismApiError> {
         let Some(prism) = self.prism else {
             return Err(TransactionError::MissingSender.into());
         };

crates/common/src/transaction.rs

@@ -1,6 +1,9 @@
-use std::fmt::{Display, Formatter};
+use std::{
+    error::Error,
+    fmt::{Display, Formatter},
+};
 
-use anyhow::{anyhow, Result};
+use anyhow::Result;
 use celestia_types::Blob;
 use prism_keys::{Signature, SigningKey, VerifyingKey};
 use prism_serde::binary::{FromBinary, ToBinary};
@@ -118,8 +121,4 @@ impl Display for TransactionError {
     }
 }
 
-impl From<TransactionError> for anyhow::Error {
-    fn from(error: TransactionError) -> Self {
-        anyhow!(error.to_string())
-    }
-}
+impl Error for TransactionError {}

crates/keys/src/verifying_keys.rs

@@ -76,11 +76,11 @@ impl VerifyingKey {
     /// Returns the byte representation of the public key.
     pub fn to_bytes(&self) -> Vec<u8> {
         match self {
-            VerifyingKey::Ed25519(vk) => vk.to_bytes().to_vec(),
-            VerifyingKey::Secp256k1(vk) => vk.to_sec1_bytes().to_vec(),
-            VerifyingKey::Secp256r1(vk) => vk.to_sec1_bytes().to_vec(),
-            VerifyingKey::Eip191(vk) => vk.to_sec1_bytes().to_vec(),
-            VerifyingKey::CosmosAdr36(vk) => vk.to_sec1_bytes().to_vec(),
+            VerifyingKey::Ed25519(vk) => vk.as_bytes().to_vec(),
+            VerifyingKey::Secp256k1(vk) => vk.to_encoded_point(true).as_bytes().to_vec(),
+            VerifyingKey::Secp256r1(vk) => vk.to_encoded_point(true).as_bytes().to_vec(),
+            VerifyingKey::Eip191(vk) => vk.to_encoded_point(true).as_bytes().to_vec(),
+            VerifyingKey::CosmosAdr36(vk) => vk.to_encoded_point(true).as_bytes().to_vec(),
         }
     }