fix(prover): test_restart_sync_from_scratch

[distractedm1nd]

Summary by CodeRabbit

• Tests

  • Improved reliability and efficiency of the prover synchronization restart test by introducing cancellation handling, explicit resource cleanup, and a timeout mechanism.
  • Enhanced test coverage with a new asynchronous proof verification method available in test builds.

• Refactor

  • Streamlined and clarified epoch processing logic for better maintainability and efficiency, particularly around verification and data extraction.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
prism	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 27, 2025 8:42am

[coderabbitai]

Walkthrough

The changes introduce a test-only proof verification method to the ProverEngine, reorganize and clarify the epoch processing logic in the Syncer, and update a test to use cancellation tokens and timeouts for controlled prover shutdown and restart. The verification keys JSON file is updated with new key values. No public API changes are made outside of test configurations.

Changes

File(s)	Change Summary
crates/node_types/prover/src/prover_engine.rs	Added a test-only async method verify_proof to ProverEngine for verifying mock proofs in tests.
crates/node_types/prover/src/syncer.rs	Refactored process_epoch for clearer logic, conditional compilation for proof verification, and variable reuse.
crates/node_types/prover/src/prover/tests/mod.rs	Updated test_restart_sync_from_scratch to use a shared CancellationToken, explicit cleanup, and a test timeout.
verification_keys/keys.json	Updated hexadecimal string values for base_vk and recursive_vk keys with new values.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test
    participant Prover1 as Prover (First Instance)
    participant Prover2 as Prover (Second Instance)
    participant DB as Database

    Test->>Prover1: Start with CancellationToken
    Prover1->>DB: Sync and commit epochs
    Test->>Prover1: Cancel operation
    Prover1-->>Test: Return commitment
    Test->>Prover2: Start with new DB and same config
    Prover2->>DB: Sync epochs
    Prover2-->>Test: Return new commitment
    Test->>Test: Assert commitments match and within timeout

Loading

Possibly related PRs

• deltadevsde/prism#342: Builds upon trait-based abstraction and mockability of FinalizedEpoch used in process_epoch verification.
• deltadevsde/prism#314: Related to the use of CancellationToken in prover setup and tests for graceful shutdown.
• deltadevsde/prism#232: Related to prover client setup and test behavior, overlapping with prover instantiation logic.

Suggested labels

bug

Suggested reviewers

• sebasti810

Poem

In the warren where proofs are spun,
A token cancels, the test is done.
Provers pause, then leap anew,
Commitments checked—consistency in view!
With careful hops and timeouts set,
This code is one a bunny won’t forget.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0a8bb8 and 5035a8f.

📒 Files selected for processing (2)

• crates/node_types/prover/src/syncer.rs (3 hunks)
• verification_keys/keys.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• verification_keys/keys.json

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/node_types/prover/src/syncer.rs

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: clippy
• GitHub Check: coverage
• GitHub Check: unused dependencies
• GitHub Check: unit-test
• GitHub Check: integration-test
• GitHub Check: build-and-push-image
• GitHub Check: Analyze (javascript-typescript)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch fix-prover-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.