Skip to content

fix(prover): test_prover_fullnode_commitment_sync_with_racing_transactions #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

fix(prover): test_prover_fullnode_commitment_sync_with_racing_transactions #356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59ce877
fix(prover): test_prover_fullnode_commitment_sync_with_racing_transac…
distractedm1nd Jun 27, 2025
af46487
forgot import
distractedm1nd Jun 27, 2025
766485e
Merge branch 'main' into fix-race
distractedm1nd Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions crates/node_types/prover/src/prover/tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ async fn test_prover_fullnode_commitment_sync_with_racing_transactions() {
let mut prover_synced = false;
let mut fullnode_synced = false;

for _ in 0..50 {
for _ in 0..10 {
// 5 second timeout
let prover_height = prover.get_db().get_last_synced_height().unwrap_or(0);
let fullnode_height = fullnode.get_db().get_last_synced_height().unwrap_or(0);
Expand All @@ -383,7 +383,7 @@ async fn test_prover_fullnode_commitment_sync_with_racing_transactions() {
break;
}

tokio::time::sleep(Duration::from_millis(100)).await;
tokio::time::sleep(Duration::from_millis(500)).await;
}

assert!(
Expand All @@ -401,7 +401,7 @@ async fn test_prover_fullnode_commitment_sync_with_racing_transactions() {
}

// Wait a bit for transactions to be processed
tokio::time::sleep(Duration::from_millis(100)).await;
tokio::time::sleep(Duration::from_millis(150)).await;

// Submit racing transactions that arrive while prover is creating proof
for transaction in racing_transactions {
Expand All @@ -419,8 +419,9 @@ async fn test_prover_fullnode_commitment_sync_with_racing_transactions() {
assert!(epoch_found, "Prover should have created an epoch");

// Wait for fullnode to sync the epoch
// If this test flakes, it could be because it needs a tiny bit more time here
tokio::time::sleep(Duration::from_millis(5000)).await;
while prover.get_commitment().await.unwrap() != fullnode.get_commitment().await.unwrap() {
tokio::time::sleep(Duration::from_millis(200)).await;
}

// Both nodes should have the same commitment despite racing transactions
let prover_commitment = prover.get_commitment().await.unwrap();
Expand Down