Fix BaseTypes deserialization with System.Text.Json #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eNeRGy164
commented
Jun 26, 2025
eNeRGy164
commented
- Fix BaseTypes deserialization with System.Text.Json - add BaseTypes parameter to JsonConstructor
* Fix BaseTypes deserialization with System.Text.Json - add BaseTypes parameter to JsonConstructor Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: eNeRGy164 <10671831+eNeRGy164@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with BaseTypes deserialization using System.Text.Json by adding a BaseTypes parameter to the TypeDescription constructor and updating the tests accordingly.
- Added unit tests in TextJsonDeserializationTests.cs to verify BaseTypes deserialization.
- Added equivalent unit tests in NewtonsoftDeserializationTests.cs.
- Updated the TypeDescription constructor to accept and assign a BaseTypes parameter.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/DendroDocs.Shared.Tests/Serialization/TextJsonDeserializationTests.cs | Added a test verifying BaseTypes are correctly deserialized using System.Text.Json. |
| tests/DendroDocs.Shared.Tests/Serialization/NewtonsoftDeserializationTests.cs | Added a test verifying BaseTypes are correctly deserialized using Newtonsoft.Json. |
| src/DendroDocs.Shared/Descriptions/TypeDescription.cs | Updated the constructor to include a BaseTypes parameter and assign it to the BaseTypes collection. |
Pull Request Test Coverage Report for Build 15905036921Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.