Merge branch 'master' into net_addr_support

Author: denizzzka

.github/workflows/ci.yml

@@ -21,11 +21,11 @@ concurrency:
 jobs:
   setup:
     name: 'Load job configuration'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     outputs:
       compilers: ${{ steps.load-config.outputs.compilers }}
     steps:
-    - uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579
+    - uses: actions/checkout@v4
     # This step checks if we want to skip CI entirely, then outputs the compilers to be used for
     # each job. A little overkill, as we don't intend to support multiple platforms, but I digress.
     - id: load-config
@@ -56,7 +56,7 @@ jobs:
 
   ci:
     name: '[ci] ${{ matrix.dc }}/${{ matrix.build }}-${{ matrix.stat_type }}'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: setup
     # Only run if the setup phase explicitly defined compilers to be used
     if: ${{ fromJSON(needs.setup.outputs.compilers) != '' && fromJSON(needs.setup.outputs.compilers) != '[]' }}
@@ -91,15 +91,15 @@ jobs:
           stat_type: none
     steps:
       - name: Checkout repo 
-        uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579
+        uses: actions/checkout@v4
       - name: Setup D compiler 
-        uses: dlang-community/setup-dlang@763d869b4d67e50c3ccd142108c8bca2da9df166
+        uses: dlang-community/setup-dlang@v1.3.0
         with:
           compiler: ${{ matrix.dc }}
       - name: Install dependencies
         run: sudo apt-get -y update && sudo apt-get -y install libpq-dev libevent-dev libcurl4-gnutls-dev postgresql
       - name: Cache dub dependencies
-        uses: actions/cache@937d24475381cd9c75ae6db12cb4e79714b926ed
+        uses: actions/cache@v4
         with:
           path: ~/.dub/packages
           key: ubuntu-latest-build-${{ hashFiles('**/dub.sdl', '**/dub.json') }}
@@ -125,4 +125,4 @@ jobs:
         shell: bash
       - name: Upload coverage data
         if: matrix.build == 'tests_and_cov'
-        uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b
+        uses: codecov/codecov-action@v2

.github/workflows/docs.yml

@@ -17,7 +17,7 @@ concurrency:
 jobs:
   build_docs:
     name: Build documentation
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     permissions:
       # Allow this action and this action only to write to the repo itself
       contents: write

src/dpq2/result.d

@@ -503,6 +503,7 @@ struct ArrayProperties
 {
     OidType OID = OidType.Undefined; /// Oid
     int[] dimsSize; /// Dimensions sizes info
+    int[] leftBounds; /// Left bounds of each dimension. Can differ from 1 for slices. Useful to restore coordinates inside of a slice.
     size_t nElems; /// Total elements
     package size_t dataOffset;
 
@@ -540,26 +541,21 @@ struct ArrayProperties
         dataOffset = ArrayHeader_net.sizeof + Dim_net.sizeof * nDims;
 
         dimsSize = new int[nDims];
+        leftBounds = new int[nDims];
 
         // Recognize dimensions of array
         for( auto i = 0; i < nDims; ++i )
         {
             Dim_net* d = (cast(Dim_net*) (h + 1)) + i;
 
             const dim_size = bigEndianToNative!int(d.dim_size);
-            const lbound = bigEndianToNative!int(d.lbound);
+            leftBounds[i] = bigEndianToNative!int(d.lbound);
 
             if(dim_size < 0)
                 throw new ValueConvException(ConvExceptionType.CORRUPTED_ARRAY,
                     "Dimension size is negative ("~to!string(dim_size)~")",
                 );
 
-            // FIXME: What is lbound in postgresql array reply?
-            if(!(lbound == 1))
-                throw new ValueConvException(ConvExceptionType.CORRUPTED_ARRAY,
-                    "Please report if you came across this error! lbound=="~to!string(lbound),
-                );
-
             dimsSize[i] = dim_size;
 
             if(i == 0) // first dimension

src/dpq2/value.d

@@ -90,7 +90,7 @@ struct Value
         import std.exception;
         import core.exception;
 
-        enforce!AssertError(!isNull, "Attempt to read NULL value", __FILE__, __LINE__);
+        enforce!AssertError(!isNull, "Attempt to read SQL NULL value", __FILE__, __LINE__);
 
         return _data;
     }