-
Notifications
You must be signed in to change notification settings - Fork 29
inet and cidr types support #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 87.08% 85.98% -1.10%
==========================================
Files 21 22 +1
Lines 1649 1670 +21
==========================================
Hits 1436 1436
- Misses 213 234 +21 ☔ View full report in Codecov by Sentry. |
9dec09e
to
6063140
Compare
@llucenic I completely reworked your code related to network addresses support because wire protocol turned out to be different. It would be great if you tried this PR on your project |
Thank you for letting me know. Do you wait for my confirmation in order to merge this one into master or are there any other reasons it is not merged yet? |
Reason is because maybe some necessary address data may not be public, for example, and it will be impossible to build project. And you're the only one using the |
a751a46
to
abac1de
Compare
Your approach of distinguished (templated) struct types InetAddress and CidrAddress seems to invalidate my use case. I need to perform data transformation based on the OidType of a cell value (in a result set). How should I create an appropriate generic conversion of a cell value (based on the OidType), if there are multiple structs to be used based on some flag of the very cell data? |
For users are available
Strictly speaking, the internal structure is not "visible" to users. From their point of view, they are simply different types. (It just so happens that their structure is the same within the wire protocol.) |
Adds support for
inet
andcidr
PG types, both IPv4 and IPv6 familiesAlso adds support of conversion from
vibe.core.net.NetworkAddress