refactor: Rewrite usages of V8 inspector to the new API #30743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2025
bartlomieju
added a commit
to denoland/deno_core
that referenced
this pull request
Sep 16, 2025
Required for denoland/deno#30743 This commit changes `LocalInspectorSession` to only provide a sync API. While it might feel counterintuitive, as it is now the callers responsibility to handle request/response cycles, this change actually greatly simplifies inspector implementation and gives granular control over behavior of inspector. The main change is that sync sessions, no longer require event loop ticks to make progress - ie. sending a message is fully synchronous - because there no channels involved. This leads to the fact that "responses" (which are actually callbacks) are most often produces when the message is sent and returned. Thanks to this change, it's now possible to easily implement interactions with V8 coverage collection and profiler inspector domains.
|
@petamoriken this PR updates |
devsnek
approved these changes
Sep 17, 2025
Tango992
pushed a commit
to Tango992/deno
that referenced
this pull request
Sep 24, 2025
Based on denoland/deno_core#1193. This commit rewrites 3 parts of the system to use a new "sync" V8 inspector API exposed by `deno_core`: - REPL - coverage collection - hot module replacement Turns out the async abstraction over V8 inspector was unnecessary and actually greatly complicated usage of the inspector. Towards denoland#13572 Towards denoland#13206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on denoland/deno_core#1193.
This commit rewrites 3 parts of the system to use a new "sync"
V8 inspector API exposed by
deno_core:Turns out the async abstraction over V8 inspector was unnecessary
and actually greatly complicated usage of the inspector.
Towards #13572
Towards #13206