feat: V8 14.0 #1187
Merged
feat: V8 14.0 #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
commented
Sep 8, 2025
littledivy
reviewed
Sep 8, 2025
Comment on lines
136
to
138
| RUSTFLAGS: >- | ||
| -D warnings -Cdebuginfo=0 ${{ inputs.os == 'windows-2022-xl' && | ||
| '-Clink-arg=/DEBUG:NONE' || '' }} |
There was a problem hiding this comment.
Not sure if its the increased disk space or this /DEBUG:None flg that fixed it. I guess we'll know when this is removed.
Also I noticed in your early attempt to disable debug info @bartlomieju that the option is not really passed all the way down to the linker. In this commit 310ff73, the final linker command still contains /DEBUG - not sure why.
6 tasks
bartlomieju
approved these changes
Sep 8, 2025
bartlomieju
added a commit
that referenced
this pull request
Sep 18, 2025
Reverting some of the changes from #1187, that were blocking the V8 upgrade but resulted in removal of debug symbols for Windows. The key to solve the PDB issue is to use `-Csymbol-mangling-version=v0` compiler flag. See for more details rust-lang/rust#141626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a change to
op2macro that enables& v8::Isolateor
&mut v8::Isolateas op argument.For the time being debug info has been disabled on Windows,
because of running into PDB errors.