From 05b3ad8128ed2be38e3a1e6cfbcf60c5f3780b77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Wed, 10 Sep 2025 23:54:19 +0200 Subject: [PATCH 1/2] fix: restore debug symbols for Windows --- .github/workflows/ci-job.yml | 9 +-------- .github/workflows/ci-test/action.yml | 4 ---- ops/op2/test_cases_fail/lifetimes.rs | 1 + ops/op2/test_cases_fail/lifetimes.stderr | 8 -------- 4 files changed, 2 insertions(+), 20 deletions(-) diff --git a/.github/workflows/ci-job.yml b/.github/workflows/ci-job.yml index 08934fb96..28f0440aa 100644 --- a/.github/workflows/ci-job.yml +++ b/.github/workflows/ci-job.yml @@ -132,11 +132,4 @@ jobs: CARGO_INCREMENTAL: 0 GH_ACTIONS: 1 RUST_BACKTRACE: full - # NOTE(bartlomieju): during upgrade to V8 14.0 we had to disable debug info - # because we were running into PDB errors. - RUSTFLAGS: >- - -D warnings -Cdebuginfo=0 ${{ inputs.os == 'windows-2022' && - '-Clink-arg=/DEBUG:NONE' || '' }} - RUSTDOCFLAGS: >- - -D warnings -Cdebuginfo=0 ${{ inputs.os == 'windows-2022' && - '-Clink-arg=/DEBUG:NONE' || '' }} \ No newline at end of file + RUSTFLAGS: -D warnings diff --git a/.github/workflows/ci-test/action.yml b/.github/workflows/ci-test/action.yml index dbcecdd3a..2c8f46a7d 100644 --- a/.github/workflows/ci-test/action.yml +++ b/.github/workflows/ci-test/action.yml @@ -6,10 +6,6 @@ runs: shell: bash run: |- cargo nextest run --workspace --release --features "deno_core/default deno_core/include_js_files_for_snapshotting deno_core/unsafe_runtime_options deno_core/unsafe_use_unprotected_platform" --tests --examples --exclude deno_ops_compile_test_runner - - - name: Cargo test (docs) - shell: bash - run: |- cargo test --doc - name: Run examples diff --git a/ops/op2/test_cases_fail/lifetimes.rs b/ops/op2/test_cases_fail/lifetimes.rs index bdf4dea59..654658735 100644 --- a/ops/op2/test_cases_fail/lifetimes.rs +++ b/ops/op2/test_cases_fail/lifetimes.rs @@ -2,6 +2,7 @@ #![deny(warnings)] deno_ops_compile_test_runner::prelude!(); use deno_core::GarbageCollected; +use deno_core::v8; struct Wrap; diff --git a/ops/op2/test_cases_fail/lifetimes.stderr b/ops/op2/test_cases_fail/lifetimes.stderr index 1880c904c..c6fbb899c 100644 --- a/ops/op2/test_cases_fail/lifetimes.stderr +++ b/ops/op2/test_cases_fail/lifetimes.stderr @@ -1,11 +1,3 @@ -error[E0433]: failed to resolve: use of unresolved module or unlinked crate `v8` - --> $WORKSPACE/ops/op2/test_cases_fail/lifetimes.rs - | - | fn trace(&self, _visitor: &mut v8::cppgc::Visitor) {} - | ^^ use of unresolved module or unlinked crate `v8` - | - = help: if you wanted to use a crate named `v8`, use `cargo add v8` to add it to your `Cargo.toml` - error[E0716]: temporary value dropped while borrowed --> $WORKSPACE/ops/op2/test_cases_fail/lifetimes.rs | From c618c9d187d3e6c9b4bfac21e49a96012777d2b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 18 Sep 2025 13:26:41 +0200 Subject: [PATCH 2/2] symbol mangling --- .github/workflows/ci-job.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci-job.yml b/.github/workflows/ci-job.yml index 28f0440aa..450be4747 100644 --- a/.github/workflows/ci-job.yml +++ b/.github/workflows/ci-job.yml @@ -132,4 +132,11 @@ jobs: CARGO_INCREMENTAL: 0 GH_ACTIONS: 1 RUST_BACKTRACE: full - RUSTFLAGS: -D warnings + # NOTE(bartlomieju): during upgrade to V8 14.0 we had to disable debug info + # because we were running into PDB errors. + RUSTFLAGS: >- + -D warnings ${{ inputs.os == 'windows-2022' && + '-Csymbol-mangling-version=v0' || '' }} + RUSTDOCFLAGS: >- + -D warnings ${{ inputs.os == 'windows-2022' && + '-Csymbol-mangling-version=v0' || '' }}