Skip to content

fix: restore debug symbols for Windows #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

fix: restore debug symbols for Windows #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05b3ad8
fix: restore debug symbols for Windows
bartlomieju Sep 10, 2025
c618c9d
symbol mangling
bartlomieju Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,11 @@ jobs:
CARGO_INCREMENTAL: 0
GH_ACTIONS: 1
RUST_BACKTRACE: full
# NOTE(bartlomieju): during upgrade to V8 14.0 we had to disable debug info
# NOTE(bartlomieju): during upgrade to V8 14.0 we had to disable debug info
# because we were running into PDB errors.
RUSTFLAGS: >-
-D warnings -Cdebuginfo=0 ${{ inputs.os == 'windows-2022' &&
'-Clink-arg=/DEBUG:NONE' || '' }}
-D warnings ${{ inputs.os == 'windows-2022' &&
'-Csymbol-mangling-version=v0' || '' }}
RUSTDOCFLAGS: >-
-D warnings -Cdebuginfo=0 ${{ inputs.os == 'windows-2022' &&
'-Clink-arg=/DEBUG:NONE' || '' }}
-D warnings ${{ inputs.os == 'windows-2022' &&
'-Csymbol-mangling-version=v0' || '' }}
4 changes: 0 additions & 4 deletions .github/workflows/ci-test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ runs:
shell: bash
run: |-
cargo nextest run --workspace --release --features "deno_core/default deno_core/include_js_files_for_snapshotting deno_core/unsafe_runtime_options deno_core/unsafe_use_unprotected_platform" --tests --examples --exclude deno_ops_compile_test_runner

- name: Cargo test (docs)
shell: bash
run: |-
cargo test --doc

- name: Run examples
Expand Down
1 change: 1 addition & 0 deletions ops/op2/test_cases_fail/lifetimes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#![deny(warnings)]
deno_ops_compile_test_runner::prelude!();
use deno_core::GarbageCollected;
use deno_core::v8;

struct Wrap;

Expand Down
8 changes: 0 additions & 8 deletions ops/op2/test_cases_fail/lifetimes.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
error[E0433]: failed to resolve: use of unresolved module or unlinked crate `v8`
--> $WORKSPACE/ops/op2/test_cases_fail/lifetimes.rs
|
| fn trace(&self, _visitor: &mut v8::cppgc::Visitor) {}
| ^^ use of unresolved module or unlinked crate `v8`
|
= help: if you wanted to use a crate named `v8`, use `cargo add v8` to add it to your `Cargo.toml`

error[E0716]: temporary value dropped while borrowed
--> $WORKSPACE/ops/op2/test_cases_fail/lifetimes.rs
|
Expand Down
Loading