refactor: rewrite inspector implementation #1192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
- Coverage 81.43% 79.73% -1.71%
==========================================
Files 97 100 +3
Lines 23877 25898 +2021
==========================================
+ Hits 19445 20649 +1204
- Misses 4432 5249 +817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bartlomieju
changed the title
bartlomieju
added a commit
that referenced
this pull request
Sep 17, 2025
Fixing some of the fall out from #1193. Testing in CLI it turned out that there's a double RefCell borrow panic occuring, when running the REPL - when the exception was raised when evaluating an expression - and said expression was evaluated as part of dispatching an inspector message - the `op_dispatch_exception` op was called that tries to mutable borrow the inspector instance. This is now avoided by storing `SessionContainer` in the `LocalInspectorSession`, instead of `JsRuntimeInspector`. This will be further simplified in follow up PRs like #1192.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to replace
LocalInspectorSessionthat abstract interaction into async Rust.