fix(inspector): avoid double RefCell borrow #1195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some of the fall out from #1193.
Testing in CLI it turned out that there's a double RefCell borrow panic occuring,
when running the REPL - when the exception was raised when evaluating an expression -
and said expression was evaluated as part of dispatching an inspector message
op_dispatch_exception
op was called that tries to mutable borrow theinspector instance.
This is now avoided by storing
SessionContainer
in theLocalInspectorSession
,instead of
JsRuntimeInspector
.This will be further simplified in follow up PRs like #1192.