feat(BREAKING): change inspector API to match new V8 API #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
approved these changes
Sep 18, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 81.43% 79.62% -1.82%
==========================================
Files 97 100 +3
Lines 23877 25783 +1906
==========================================
+ Hits 19445 20530 +1085
- Misses 4432 5253 +821 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bartlomieju
force-pushed
the
inspector_changes
branch
from
9951f91 to
589bb68
Compare
bartlomieju
added a commit
to denoland/deno
that referenced
this pull request
Sep 20, 2025
Ref denoland/deno_core#1196 There are no functional changes in this PR - just adjusting to the API change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts inspector API usage to changes from denoland/rusty_v8#1853.
The main change is
Rc<JsRuntimeInspector>instead ofRc<RefCell<JsRuntimeInspector>>.