-
Notifications
You must be signed in to change notification settings - Fork 131
Middleware support for Parameters #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
==========================================
- Coverage 81.43% 79.61% -1.83%
==========================================
Files 97 100 +3
Lines 23877 25783 +1906
==========================================
+ Hits 19445 20527 +1082
- Misses 4432 5256 +824 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a simple test for this in core/runtime/tests/misc.rs
?
Done! |
Made it so parameters make it to middleware (if no parameters then middleware is unchanged)