Skip to content

Conversation

nathanwhit
Copy link
Member

No description provided.

@nathanwhit nathanwhit marked this pull request as ready for review September 22, 2025 22:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 80.81458% with 179 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.62%. Comparing base (0c7f83e) to head (e9c55e8).
⚠️ Report is 345 commits behind head on main.

Files with missing lines Patch % Lines
core/ops_builtin_v8.rs 57.39% 49 Missing ⚠️
core/convert.rs 50.00% 18 Missing ⚠️
core/runtime/ops_rust_to_v8.rs 74.41% 11 Missing ⚠️
core/modules/mod.rs 28.57% 10 Missing ⚠️
core/webidl.rs 77.77% 10 Missing ⚠️
core/ops_builtin.rs 38.46% 8 Missing ⚠️
core/runtime/op_driver/op_results.rs 50.00% 8 Missing ⚠️
core/runtime/jsruntime.rs 95.20% 7 Missing ⚠️
serde_v8/magic/any_value.rs 0.00% 6 Missing ⚠️
serde_v8/magic/detached_buffer.rs 0.00% 6 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
- Coverage   81.43%   79.62%   -1.82%     
==========================================
  Files          97      100       +3     
  Lines       23877    25791    +1914     
==========================================
+ Hits        19445    20535    +1090     
- Misses       4432     5256     +824     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nathanwhit nathanwhit enabled auto-merge (squash) September 22, 2025 23:40
Comment on lines +1019 to +1022
let main_realm = {
v8::scope_with_context!(context_scope, &mut isolate, &main_context);
let scope = context_scope;
let context = v8::Local::new(scope, &main_context);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof, unlucky that it needs to be run in a block, this diff is huge...

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit nathanwhit merged commit bf1ca69 into denoland:main Sep 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants