Skip to content

Conversation

bartlomieju
Copy link
Member

Pulled out from #1198 this commit
modernizes InspectorServer implementation - it now relies more on tokio
than futures crate.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 0% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.65%. Comparing base (0c7f83e) to head (899830d).
⚠️ Report is 348 commits behind head on main.

Files with missing lines Patch % Lines
dcore/src/inspector_server.rs 0.00% 98 Missing ⚠️
dcore/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   81.43%   79.65%   -1.79%     
==========================================
  Files          97      100       +3     
  Lines       23877    25778    +1901     
==========================================
+ Hits        19445    20533    +1088     
- Misses       4432     5245     +813     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 761b84d into denoland:main Sep 24, 2025
18 checks passed
@bartlomieju bartlomieju deleted the modernize_inspector_server branch September 24, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants