-
Notifications
You must be signed in to change notification settings - Fork 131
fix: panic, unwrap to unwrap_or #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peko-thunder
wants to merge
13
commits into
denoland:main
Choose a base branch
from
peko-thunder:issue/deno/#23805
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
74129c4
fix: panic, unwrap to unwrap_or
peko-thunder e90685e
test: add error_variable_is_not_defined
peko-thunder 86a08e1
fix: run cargo fmt
peko-thunder a4e9f13
add copyright for lint
peko-thunder 5286cde
fix: Err line
peko-thunder a20b70b
change ArrayPrototypePush to a custom implementation
peko-thunder e245e3b
fix: Removed unneeded array copy.
peko-thunder 05054fc
fix: `ObjectDefineProperty` disallows access to `get` and `set` of `p…
peko-thunder 6ef6140
Revert to because of possible panic.
peko-thunder 8d8cfa9
Merge branch 'main' into issue/deno/#23805
ry 347693f
fix: add ts-nocheck for tsc lint
peko-thunder 737382c
Merge branch 'issue/deno/#23805' of github.com:peko-thunder/deno_core…
peko-thunder b2f0602
Merge branch 'main' into issue/deno/#23805
bartlomieju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
testing/integration/error_internal_method_set/error_internal_method_set.out
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
10 changes: 10 additions & 0 deletions
10
testing/integration/error_internal_method_set/error_internal_method_set.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. | ||
|
||
// This test refers to the issue. | ||
// https://github.com/denoland/deno_core/issues/744 | ||
|
||
Object.prototype.__defineSetter__(0, function () {}); | ||
|
||
// Need to dare to make errors. | ||
// For example, `ReferenceError: variable is not defined`. | ||
variable; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.