Skip to content

fix: don't panic when eval_origin is None #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't panic when eval_origin is None #869

wants to merge 1 commit into from

Conversation

lucacasonato
Copy link
Member

No description provided.

@bartlomieju
Copy link
Member

Is there a test we could add?

@lucacasonato
Copy link
Member Author

Yeah, working on it. Unfortunately quite difficult because according to V8 source code this shouldn't be able to happen 😅

@bartlomieju
Copy link
Member

Take a look at example here: denoland/deno#24782 I think it had the same (or similar) problem

@lucacasonato
Copy link
Member Author

It's a different problem. It's denoland/deno#24990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @bartlomieju