Skip to content

Conversation

bartlomieju
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Project coverage is 81.22%. Comparing base (0c7f83e) to head (8b45e26).
Report is 316 commits behind head on main.

Files with missing lines Patch % Lines
core/inspector.rs 0.00% 71 Missing ⚠️
core/ops_builtin_v8.rs 0.00% 27 Missing ⚠️
core/runtime/jsruntime.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
- Coverage   81.43%   81.22%   -0.22%     
==========================================
  Files          97       98       +1     
  Lines       23877    24882    +1005     
==========================================
+ Hits        19445    20211     +766     
- Misses       4432     4671     +239     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}
/// A local inspector session that can be used to send and receive protocol messages directly on
/// the same thread as an isolate.
pub struct LocalInspectorSession {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This struct should probably be let go from deno_core, but I'm still weighing it. node:inspector needs low level access to handle notifications/message response it self, but REPL, Jupyter and HMR runner rely on high-level API to await responses when posting.

@bartlomieju
Copy link
Member Author

Closing in favor of #938

@bartlomieju bartlomieju closed this Nov 6, 2024
@bartlomieju bartlomieju deleted the inspector_rewrite branch November 6, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants