Skip to content

use clone in property factory #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 1, 2023
Merged

use clone in property factory #408

merged 12 commits into from
Feb 1, 2023

Conversation

stuartwk
Copy link
Contributor

Description

Use OpenZeppelin Clones to create new properties, to reduce cost.

Why is this change needed?

Potentially reduces cost for end user when creating a new Property.

Related Issues

Closes #373

Code of Conduct

  • By submitting this pull request, I confirm I've read and complied with the CoC 🖖

@stuartwk stuartwk requested a review from aggre July 21, 2022 07:57
aggre
aggre approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@aggre aggre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to deploy this quickly!

@stuartwk stuartwk marked this pull request as ready for review July 22, 2022 02:46
aggre
aggre requested changes Jul 25, 2022
View reviewed changes
@stuartwk stuartwk requested a review from aggre July 25, 2022 06:20
aggre
aggre approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@aggre aggre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are great!

@aggre
Copy link
Member

aggre commented Jan 10, 2023 •
edited
Loading

Deployment flow:

  1. edit .env: required keys =
ADMIN
PROPERTY_FACTORY_PROXY
ADDRESS_REGISTRY_PROXY
  1. run yarn build
  2. run mv migrations/update/1_update-property-factory-with-seed-property.js migrations
  3. run yarn deploy [polygon_testnet|polygon_mainnet|arbitrum_mainnet]
  4. run yarn truffle run verify Property@[deployed property address] --network [polygon_testnet|polygon_mainnet|arbitrum_mainnet]
  5. run yarn truffle run verify PropertyFactory@[deployed property factory address] --network [polygon_testnet|polygon_mainnet|arbitrum_mainnet]

@aggre aggre merged commit 99d4437 into main Feb 1, 2023
@aggre aggre deleted the property-clones branch February 1, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aggre aggre aggre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OTHER] PropertyFactory should be used Clones.clone
2 participants
@stuartwk @aggre