Skip to content

do not force type of ssh_gateway_ports #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion molecule/mysql_hardening/prepare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
- ansible_distribution_major_version|int < 20

- name: Install required MySQL Python libraries on RHEL
ansible.builtin.yum:
ansible.builtin.dnf:
name: "{% if 'python3' in ansible_python_interpreter | default('') %}python36-PyMySQL{% else %}python2-PyMySQL{% endif %}"
when:
- ansible_os_family == "RedHat"
Expand Down
2 changes: 1 addition & 1 deletion molecule/os_hardening/prepare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
when: ansible_facts.os_family == 'Archlinux'

- name: Install required tools on RHEL # noqa ignore-errors
ansible.builtin.yum:
ansible.builtin.dnf:
name:
- openssh-clients
- openssh
Expand Down
2 changes: 1 addition & 1 deletion molecule/os_hardening_vm/prepare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
when: ansible_facts.os_family == 'Archlinux'

- name: Install required tools on RHEL # noqa ignore-errors
ansible.builtin.yum:
ansible.builtin.dnf:
name:
- openssh-clients
- openssh
Expand Down
2 changes: 1 addition & 1 deletion molecule/ssh_hardening/prepare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
when: ansible_facts.distribution == 'Fedora'

- name: Install packages # noqa ignore-errors
ansible.builtin.yum:
ansible.builtin.dnf:
name:
- openssh-clients
- openssh-server
Expand Down
2 changes: 1 addition & 1 deletion molecule/ssh_hardening_custom_tests/converge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
- root
network_ipv6_enable: true
ssh_allow_tcp_forwarding: "yes"
ssh_gateway_ports: true
ssh_gateway_ports: "clientspecified"
ssh_allow_agent_forwarding: true
ssh_server_permit_environment_vars: "yes"
ssh_server_accept_env_vars: PWD HTTP_PROXY
Expand Down
2 changes: 1 addition & 1 deletion molecule/ssh_hardening_custom_tests/prepare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
when: ansible_facts.distribution == 'Fedora'

- name: Install packages # noqa ignore-errors
ansible.builtin.yum:
ansible.builtin.dnf:
name:
- openssh-clients
- openssh-server
Expand Down
2 changes: 1 addition & 1 deletion roles/os_hardening/tasks/pam_rhel.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
- name: Install sssd-clients
ansible.builtin.yum:
ansible.builtin.dnf:
name: sssd-client
state: present
when:
Expand Down
2 changes: 1 addition & 1 deletion roles/os_hardening/tasks/yum.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
- /etc/yum/pluginconf.d/rhnplugin.conf

- name: Remove deprecated or insecure packages | package-01 - package-09
ansible.builtin.yum:
ansible.builtin.dnf:
name: "{{ os_security_packages_list }}"
state: absent
when: os_security_packages_clean | bool
2 changes: 1 addition & 1 deletion roles/ssh_hardening/meta/argument_specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ argument_specs:
you can specify `'yes'`, `'no'`, `'all'`, `'local'`or`'remote'`.
ssh_gateway_ports:
default: false
type: bool
type: raw
description: Set to `false` to disable binding forwarded ports to non-loopback
addresses. Set to `true` to force binding on wildcard address. Set to `clientspecified`
to allow the client to specify which address to bind to.
Expand Down
Loading