fix: verify group exists #875
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrea11 <10788630+andrea11@users.noreply.github.com>
|
LGTM. Can you please fix the linting-errors? |
Signed-off-by: andrea11 <10788630+andrea11@users.noreply.github.com>
|
@rndmh3ro can you merge this PR? |
|
Anyone could merge this PR? (@rndmh3ro) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to fix an issue that is there when try to change the ownership of file systems.
Currently, depending on different versions of Ubuntu, the syslog group can or cannot be there. Therefore, I added a check and eventually create the missing groups.
This is linked to #614 and #746.
I am not sure that my approach is the correct one. Maybe, if a group does not exists, we should just use 'root' instead. What is your advice?