Skip to content

Commit 5216ec6

Browse files
Merge pull request #100 from Logicworks/fix/regression-debian-file-perms
fix(6.1): regression expected_gid
2 parents 81f7434 + 0e0141f commit 5216ec6

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

controls/6_1_system_file_permissions.rb

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,10 @@
1515
#
1616
# author: Kristian Vlaardingerbroek
1717

18-
cis_level = attribute('cis_level')
18+
cis_level = input('cis_level')
19+
20+
expected_gid = 0
21+
expected_gid = 42 if os.debian? || os.suse? || os.name == 'alpine'
1922

2023
title '6.1 System File Permissions'
2124

@@ -129,13 +132,10 @@
129132
shadow_files = ['/etc/shadow']
130133
shadow_files << '/usr/share/baselayout/shadow' if file('/etc/nsswitch.conf').content =~ /^shadow:\s+(\S+\s+)*usrfiles/
131134

132-
expected_gid = 0
133-
expected_gid = 42 if os.debian?
134-
135135
shadow_files.each do |f|
136136
describe file(f) do
137137
it { should exist }
138-
it { should_not be_more_permissive_than('0644') }
138+
it { should_not be_more_permissive_than('0640') }
139139
its('uid') { should cmp 0 }
140140
its('gid') { should cmp expected_gid }
141141
end
@@ -191,9 +191,6 @@
191191
gshadow_files = ['/etc/gshadow']
192192
gshadow_files << '/usr/share/baselayout/gshadow' if file('/etc/nsswitch.conf').content =~ /^gshadow:\s+(\S+\s+)*usrfiles/
193193

194-
expected_gid = 0
195-
expected_gid = 42 if os.debian?
196-
197194
gshadow_files.each do |f|
198195
describe file(f) do
199196
it { should exist }
@@ -248,7 +245,7 @@
248245
it { should_not be_more_permissive_than('0640') }
249246

250247
its('uid') { should cmp 0 }
251-
its('gid') { should cmp 0 }
248+
its('gid') { should cmp expected_gid }
252249
end
253250
end
254251

@@ -297,7 +294,7 @@
297294
it { should exist }
298295
it { should_not be_more_permissive_than('0640') }
299296
its('uid') { should cmp 0 }
300-
its('gid') { should cmp 0 }
297+
its('gid') { should cmp expected_gid }
301298
end
302299
end
303300

0 commit comments

Comments
 (0)