feat: Show "View another" only after attachment delivery for better UX

Author: devadathanmb

src/bot/composers/lookups/academic-calendar/composer.ts

@@ -124,17 +124,14 @@ async function handleCalendarAttachment(
     ],
     statusMessageId: statusMessage.message_id,
     context: "calendar",
+    sendViewAnotherMessage: true,
   };
 
   if (ctx.msgId !== undefined) {
     jobData.replyToMessageId = ctx.msgId;
   }
 
   await addAttachmentDeliveryJob(jobData);
-
-  await ctx.reply(`${emoji("eyes")} View another calendar?`, {
-    reply_markup: keyboard,
-  });
 }
 
 async function fetchAndDisplayCalendars(ctx: BotContext): Promise<void> {

src/bot/composers/lookups/announcements/composer.ts

@@ -122,17 +122,14 @@ async function handleAnnouncementAttachments(
     attachments,
     statusMessageId: statusMessage.message_id,
     context: "announcement",
+    sendViewAnotherMessage: true,
   };
 
   if (ctx.msgId !== undefined) {
     jobData.replyToMessageId = ctx.msgId;
   }
 
   await addAttachmentDeliveryJob(jobData);
-
-  await ctx.reply(`${emoji("eyes")} View another announcement?`, {
-    reply_markup: keyboard,
-  });
 }
 
 async function fetchAndDisplayAnnouncements(ctx: BotContext): Promise<void> {

src/bot/composers/lookups/constants.ts

@@ -1,3 +1,5 @@
+import { emoji } from "@grammyjs/emoji";
+
 /**
  * Constants for lookup composers to avoid magic numbers
  */
@@ -11,3 +13,20 @@ export const LOOKUP_CONFIG = {
   /** Initial page number for pagination */
   INITIAL_PAGE: 0,
 } as const;
+
+/**
+ * Map context types to their corresponding emojis
+ */
+export const CONTEXT_EMOJI_MAP: Record<string, string> = {
+  "calendar": emoji("calendar"),
+  "timetable": emoji("books"),
+  "announcement": emoji("paperclip"),
+  "inline query result": emoji("paperclip"),
+} as const;
+
+/**
+ * Get emoji for a given context
+ */
+export function getContextEmoji(context: string): string {
+  return CONTEXT_EMOJI_MAP[context] || emoji("paperclip");
+}

src/bot/composers/lookups/exam-timetable/composer.ts

@@ -133,17 +133,14 @@ async function handleTimetableAttachment(
     ],
     statusMessageId: statusMessage.message_id,
     context: "timetable",
+    sendViewAnotherMessage: true,
   };
 
   if (ctx.msgId !== undefined) {
     jobData.replyToMessageId = ctx.msgId;
   }
 
   await addAttachmentDeliveryJob(jobData);
-
-  await ctx.reply(`${emoji("eyes")} View another timetable?`, {
-    reply_markup: keyboard,
-  });
 }
 
 async function fetchAndDisplayTimetables(ctx: BotContext): Promise<void> {

src/workers/attachment-delivery/queue.ts

@@ -11,6 +11,7 @@ export interface AttachmentDeliveryJob {
   statusMessageId?: number;
   replyToMessageId?: number;
   context: string;
+  sendViewAnotherMessage?: boolean;
 }
 
 export const attachmentDeliveryQueue = new Queue<AttachmentDeliveryJob>(

src/workers/attachment-delivery/worker.ts

@@ -9,6 +9,8 @@ import logger from "../../utils/logger.js";
 import { emoji } from "@grammyjs/emoji";
 import { ATTACHMENT_DELIVERY_QUEUE } from "./queue.js";
 import { TelegramErrorUtils } from "../shared/utils/telegramErrorHandler.js";
+import { createViewAnotherKeyboard } from "../../bot/composers/lookups/utils.js";
+import { getContextEmoji } from "../../bot/composers/lookups/constants.js";
 
 export class AttachmentDeliveryWorker extends BaseWorker<AttachmentDeliveryJob> {
   constructor() {
@@ -123,6 +125,10 @@ export class AttachmentDeliveryWorker extends BaseWorker<AttachmentDeliveryJob>
       if (statusMessageId !== undefined) {
         await this.deleteStatusMessage(chatId, statusMessageId);
       }
+
+      if (job.data.sendViewAnotherMessage) {
+        await this.sendViewAnotherMessage(job.data.chatId, job.data.context);
+      }
     } catch (error) {
       if (statusMessageId !== undefined) {
         await this.updateErrorMessage(chatId, statusMessageId);
@@ -134,7 +140,7 @@ export class AttachmentDeliveryWorker extends BaseWorker<AttachmentDeliveryJob>
   private buildCaption(attachments: Attachment[], context: string): string {
     if (attachments.length === 0) return "";
 
-    const contextEmoji = this.getContextEmoji(context);
+    const contextEmoji = getContextEmoji(context);
     const lines = [
       `${contextEmoji} Attachments:`,
       ...attachments.map(a => a.name),
@@ -143,14 +149,19 @@ export class AttachmentDeliveryWorker extends BaseWorker<AttachmentDeliveryJob>
     return lines.join("\n");
   }
 
-  private getContextEmoji(context: string): string {
-    const emojiMap: Record<string, string> = {
-      "calendar": emoji("calendar"),
-      "timetable": emoji("books"),
-      "announcement": emoji("paperclip"),
-      "inline query result": emoji("paperclip"),
-    };
-    return emojiMap[context] || emoji("paperclip");
+  private async sendViewAnotherMessage(
+    chatId: number,
+    context: string
+  ): Promise<void> {
+    const keyboard = createViewAnotherKeyboard(context);
+    const contextEmoji = getContextEmoji(context);
+
+    await this.bot!.api.sendMessage(
+      chatId,
+      `${contextEmoji} View another ${context}?`,
+      { reply_markup: keyboard }
+    );
+    logger.debug({ chatId, context }, "Sent view another message");
   }
 
   private async deleteStatusMessage(