Skip to content

Commit d79da52

Browse files
devamitberadevamitbera
committed
run magento code stardard
1 parent c5076cb commit d79da52

9 files changed

Lines changed: 129 additions & 134 deletions

File tree

‎Block/Adminhtml/Form/Field/CmsPagesList.php‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,16 @@
33
/**
44
* A Magento 2 module named DevBera/CmsLinkToMenu
55
* Copyright (C) 2019 Copyright 2019 © amitbera.com. All Rights Reserved
6-
*
6+
*
77
* This file included in DevBera/CmsLinkToMenu is licensed under OSL 3.0
8-
*
8+
*
99
* http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
1010
* Please see LICENSE.txt for the full text of the OSL 3.0 license
1111
*/
1212

1313
namespace DevBera\CmsLinkToMenu\Block\Adminhtml\Form\Field;
1414

15-
16-
class CmsPagesList extends \Magento\Config\Block\System\Config\Form\Field\FieldArray\AbstractFieldArray
15+
class CmsPagesList extends \Magento\Config\Block\System\Config\Form\Field\FieldArray\AbstractFieldArray
1716
{
1817

1918
private $cmsPagesRenderer;
@@ -23,10 +22,10 @@ class CmsPagesList extends \Magento\Config\Block\System\Config\Form\Field\Field
2322
private $cmsPages;
2423

2524
public function __construct(
26-
\Magento\Backend\Block\Template\Context $context,
27-
\DevBera\CmsLinkToMenu\Model\Config\Source\Pages $cmsPages,
28-
array $data = array()
29-
) {
25+
\Magento\Backend\Block\Template\Context $context,
26+
\DevBera\CmsLinkToMenu\Model\Config\Source\Pages $cmsPages,
27+
array $data = []
28+
) {
3029
parent::__construct($context, $data);
3130
$this->cmsPages = $cmsPages;
3231
}
@@ -41,10 +40,11 @@ private function getCmsPagesRenderer()
4140
);
4241
$this->cmsPagesRenderer->setClass('customer_group_select');
4342
}
44-
return $this->cmsPagesRenderer ;
43+
return $this->cmsPagesRenderer ;
4544
}
4645

47-
protected function _prepareToRender(): void {
46+
protected function _prepareToRender(): void
47+
{
4848
$this->addColumn(
4949
'page_id',
5050
['label' => __('Cms Pages'), 'renderer' => $this->getCmsPagesRenderer()]
@@ -68,5 +68,5 @@ protected function _prepareArrayRow(\Magento\Framework\DataObject $row)
6868
'option_extra_attrs',
6969
$optionExtraAttr
7070
);
71-
}
71+
}
7272
}

‎Block/Adminhtml/Form/Field/Pages.php‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,16 @@
33
/**
44
* A Magento 2 module named DevBera/CmsLinkToMenu
55
* Copyright (C) 2019 Copyright 2019 © amitbera.com. All Rights Reserved
6-
*
6+
*
77
* This file included in DevBera/CmsLinkToMenu is licensed under OSL 3.0
8-
*
8+
*
99
* http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
1010
* Please see LICENSE.txt for the full text of the OSL 3.0 license
1111
*/
1212

1313

1414
namespace DevBera\CmsLinkToMenu\Block\Adminhtml\Form\Field;
1515

16-
1716
class Pages extends \Magento\Framework\View\Element\Html\Select
1817
{
1918

@@ -23,22 +22,22 @@ class Pages extends \Magento\Framework\View\Element\Html\Select
2322
private $cmsPages;
2423

2524
public function __construct(
26-
\DevBera\CmsLinkToMenu\Model\Config\Source\Pages $cmsPages,
27-
\Magento\Framework\View\Element\Context $context,
28-
array $data = array()
25+
\DevBera\CmsLinkToMenu\Model\Config\Source\Pages $cmsPages,
26+
\Magento\Framework\View\Element\Context $context,
27+
array $data = []
2928
) {
3029
parent::__construct($context, $data);
3130
$this->cmsPages = $cmsPages;
3231
}
3332
public function _toHtml()
3433
{
35-
34+
// @codingStandardsIgnoreStart
3635
if (!$this->getOptions()) {
3736
foreach ($this->cmsPages->getOptions() as $pageIndetifier => $PageTitle) {
3837
$this->addOption($pageIndetifier, addslashes($PageTitle));
3938
}
4039
}
41-
40+
// @codingStandardsIgnoreEnd
4241
return parent::_toHtml();
4342
}
4443
/**
@@ -48,5 +47,5 @@ public function _toHtml()
4847
public function setInputName($value)
4948
{
5049
return $this->setName($value);
51-
}
50+
}
5251
}

‎Model/AddItemtoMenu.php‎

Lines changed: 47 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
/**
44
* A Magento 2 module named DevBera/CmsLinkToMenu
55
* Copyright (C) 2019 Copyright 2019 © amitbera.com. All Rights Reserved
6-
*
6+
*
77
* This file included in DevBera/CmsLinkToMenu is licensed under OSL 3.0
8-
*
8+
*
99
* http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
1010
* Please see LICENSE.txt for the full text of the OSL 3.0 license
1111
*/
@@ -16,8 +16,7 @@
1616
use Magento\Framework\Data\Tree\NodeFactory;
1717
use Magento\Store\Model\ScopeInterface;
1818

19-
20-
class AddItemtoMenu
19+
class AddItemtoMenu
2120
{
2221

2322
private $homePageIdentifier;
@@ -75,16 +74,16 @@ class AddItemtoMenu
7574
private $logger;
7675

7776
public function __construct(
78-
NodeFactory $nodeFactory,
79-
\Magento\Cms\Api\PageRepositoryInterface $pageRepository,
80-
\Magento\Store\Model\StoreManagerInterface $storeManager,
81-
\Magento\Framework\UrlInterface $urlBuilder,
82-
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
83-
\Magento\Framework\Api\SearchCriteriaBuilder $searchCriteriaBuilder,
84-
\Magento\Framework\Api\FilterBuilder $filterBuilder,
85-
\Magento\Framework\Api\SortOrderBuilder $sortOrderBuilder,
86-
\DevBera\CmsLinkToMenu\Model\System\Config\Backend\FieldProcessor $fieldProcessor,
87-
\Psr\Log\LoggerInterface $logger
77+
NodeFactory $nodeFactory,
78+
\Magento\Cms\Api\PageRepositoryInterface $pageRepository,
79+
\Magento\Store\Model\StoreManagerInterface $storeManager,
80+
\Magento\Framework\UrlInterface $urlBuilder,
81+
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
82+
\Magento\Framework\Api\SearchCriteriaBuilder $searchCriteriaBuilder,
83+
\Magento\Framework\Api\FilterBuilder $filterBuilder,
84+
\Magento\Framework\Api\SortOrderBuilder $sortOrderBuilder,
85+
\DevBera\CmsLinkToMenu\Model\System\Config\Backend\FieldProcessor $fieldProcessor,
86+
\Psr\Log\LoggerInterface $logger
8887
) {
8988

9089
$this->pageRepository = $pageRepository;
@@ -101,38 +100,38 @@ public function __construct(
101100

102101
/**
103102
* Get List of Cms Pages from settings
104-
*
103+
*
105104
* @param \Magento\Theme\Block\Html\Topmenu $subject
106105
*/
107-
public function addCmsPagesToMenu($subject,$position = 'left')
106+
public function addCmsPagesToMenu($subject, $position = 'left')
108107
{
109108
$pagesIdentifierWithFieldPosition = [];
110109

111-
112-
$fieldName = $position.'_cms_pages';
110+
$fieldName = $position.'_cms_pages';
113111

114-
$pagesIdentifierWithFieldPosition = $this->fieldProcessor->getConfigValue($fieldName, $this->storeManager->getStore());
112+
$pagesIdentifierWithFieldPosition = $this->fieldProcessor
113+
->getConfigValue($fieldName, $this->storeManager->getStore());
115114

116-
// Sort $pagesIdentifierWithFieldPosition arrays in ascending order, according to the value
117-
if(!empty($pagesIdentifierWithFieldPosition)){
118-
asort($pagesIdentifierWithFieldPosition) ;
119-
}
115+
// Sort $pagesIdentifierWithFieldPosition arrays in ascending order, according to the value
116+
if (!empty($pagesIdentifierWithFieldPosition)) {
117+
asort($pagesIdentifierWithFieldPosition) ;
118+
}
120119

121-
$menuItems = $this->getPagesListWithSortOrder($pagesIdentifierWithFieldPosition);
120+
$menuItems = $this->getPagesListWithSortOrder($pagesIdentifierWithFieldPosition);
122121

123-
$homePageIdentifier = $this->getHomePageIdentifier();
122+
$homePageIdentifier = $this->getHomePageIdentifier();
124123

125-
if(!empty($menuItems)){
126-
foreach($menuItems as $page){
124+
if (!empty($menuItems)) {
125+
foreach ($menuItems as $page) {
127126
$subject->getMenu()->addChild(
128-
$this->buildMenuItem($page, $subject,$position)
129-
);
127+
$this->buildMenuItem($page, $subject, $position)
128+
);
130129
}
131130

132131
}
133132
}
134133

135-
private function buildMenuItem($page,$subject,$position)
134+
private function buildMenuItem($page, $subject, $position)
136135
{
137136
$node = $this->nodeFactory->create(
138137
[
@@ -151,7 +150,7 @@ private function buildMenuItem($page,$subject,$position)
151150
}
152151

153152
/**
154-
*
153+
*
155154
* @param array $pagesIdentifierWithFieldPosition
156155
* @return array
157156
*/
@@ -161,7 +160,7 @@ private function avaliableCmsPage($pagesIdentifierWithFieldPosition)
161160
}
162161

163162
/**
164-
*
163+
*
165164
* @param array $pagesIdentifierWithFieldPosition
166165
* @return array
167166
*/
@@ -194,18 +193,18 @@ private function getPagesListWithSortOrder($pagesIdentifierWithFieldPosition)
194193

195194
$this->searchCriteriaBuilder->setCurrentPage(1)->setPageSize(count($cmsPagesIdentifier));
196195

197-
$searchCriteria = $this->searchCriteriaBuilder->create();
198-
$pages = $this->pageRepository->getList($searchCriteria);
196+
$searchCriteria = $this->searchCriteriaBuilder->create();
197+
$pages = $this->pageRepository->getList($searchCriteria);
199198

200-
if($pages->getTotalCount() >0 ){
199+
if ($pages->getTotalCount() >0) {
201200
$items = $pages->getItems();
202-
foreach($items as $page){
203-
$result[$page->getIdentifier()] = $page;
204-
}
201+
foreach ($items as $page) {
202+
$result[$page->getIdentifier()] = $page;
203+
}
205204
}
206205

207-
foreach($pagesIdentifierWithFieldPosition as $cmsIdentifier=>$postion){
208-
if(array_key_exists($cmsIdentifier, $result)){
206+
foreach ($pagesIdentifierWithFieldPosition as $cmsIdentifier => $postion) {
207+
if (array_key_exists($cmsIdentifier, $result)) {
209208
$menuItems[] = $result[$cmsIdentifier];
210209
}
211210
}
@@ -215,32 +214,32 @@ private function getPagesListWithSortOrder($pagesIdentifierWithFieldPosition)
215214

216215
private function getCmsPageUrl($page)
217216
{
218-
if($page->getIdentifier() == $this->getHomePageIdentifier()){
217+
if ($page->getIdentifier() == $this->getHomePageIdentifier()) {
219218
return $this->urlBuilder->getUrl();
220219
}
221-
return $this->urlBuilder->getUrl(null, ['_direct' => $page->getIdentifier()]);
220+
return $this->urlBuilder->getUrl(null, ['_direct' => $page->getIdentifier()]);
222221
}
223222

224223
/**
225-
*
224+
*
226225
* @return string
227226
*/
228227
private function getHomePageIdentifier()
229228
{
230-
if(!$this->homePageIdentifier){
229+
if (!$this->homePageIdentifier) {
231230

232231
$this->homePageIdentifier = $this->scopeConfig->getValue(
233232
'web/default/cms_home_page',
234233
ScopeInterface::SCOPE_STORE
235234
);
236235
}
237-
return $this->homePageIdentifier;
236+
return $this->homePageIdentifier;
238237
}
239238
private function getCmsPageTitle($page)
240239
{
241-
if($page->getIdentifier() == $this->getHomePageIdentifier()){
240+
if ($page->getIdentifier() == $this->getHomePageIdentifier()) {
242241
return __('Home');
243242
}
244-
return __($page->getTitle());
245-
}
243+
return __($page->getTitle());
244+
}
246245
}

‎Model/Config/Source/Pages.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
/**
44
* A Magento 2 module named DevBera/CmsLinkToMenu
55
* Copyright (C) 2019 Copyright 2019 © amitbera.com. All Rights Reserved
6-
*
6+
*
77
* This file included in DevBera/CmsLinkToMenu is licensed under OSL 3.0
8-
*
8+
*
99
* http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
1010
* Please see LICENSE.txt for the full text of the OSL 3.0 license
1111
*/
@@ -14,7 +14,8 @@
1414

1515
use Magento\Cms\Model\ResourceModel\Page\CollectionFactory;
1616

17-
class Pages implements \Magento\Framework\Option\ArrayInterface {
17+
class Pages implements \Magento\Framework\Option\ArrayInterface
18+
{
1819

1920
/**
2021
* @var array
@@ -51,8 +52,7 @@ public function getOptions()
5152
{
5253
$result = [];
5354
$options = $this->toOptionArray();
54-
foreach ($options as $option)
55-
{
55+
foreach ($options as $option) {
5656
$result[$option['value']] = $option['label'];
5757
}
5858
return $result;

‎Model/System/Config/Backend/CmsPagesList.php‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,16 @@
33
/**
44
* A Magento 2 module named DevBera/CmsLinkToMenu
55
* Copyright (C) 2019 Copyright 2019 © amitbera.com. All Rights Reserved
6-
*
6+
*
77
* This file included in DevBera/CmsLinkToMenu is licensed under OSL 3.0
8-
*
8+
*
99
* http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
1010
* Please see LICENSE.txt for the full text of the OSL 3.0 license
1111
*/
1212

1313
namespace DevBera\CmsLinkToMenu\Model\System\Config\Backend;
1414

15-
16-
class CmsPagesList extends \Magento\Framework\App\Config\Value
15+
class CmsPagesList extends \Magento\Framework\App\Config\Value
1716
{
1817

1918
/**
@@ -22,20 +21,21 @@ class CmsPagesList extends \Magento\Framework\App\Config\Value
2221
private $fieldProcessor;
2322

2423
public function __construct(
25-
\Magento\Framework\Model\Context $context,
26-
\Magento\Framework\Registry $registry,
27-
\Magento\Framework\App\Config\ScopeConfigInterface $config,
28-
\Magento\Framework\App\Cache\TypeListInterface $cacheTypeList,
29-
\Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
30-
\DevBera\CmsLinkToMenu\Model\System\Config\Backend\FieldProcessor $fieldProcessor,
31-
\Magento\Framework\Data\Collection\AbstractDb $resourceCollection = null,
32-
array $data = array())
33-
{
24+
\Magento\Framework\Model\Context $context,
25+
\Magento\Framework\Registry $registry,
26+
\Magento\Framework\App\Config\ScopeConfigInterface $config,
27+
\Magento\Framework\App\Cache\TypeListInterface $cacheTypeList,
28+
\Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
29+
\DevBera\CmsLinkToMenu\Model\System\Config\Backend\FieldProcessor $fieldProcessor,
30+
\Magento\Framework\Data\Collection\AbstractDb $resourceCollection = null,
31+
array $data = []
32+
) {
3433
$this->fieldProcessor = $fieldProcessor;
3534
parent::__construct($context, $registry, $config, $cacheTypeList, $resource, $resourceCollection, $data);
3635
}
3736

38-
protected function _afterLoad() {
37+
protected function _afterLoad()
38+
{
3939
$value = $this->getValue();
4040
$value = $this->fieldProcessor->makeArrayFieldValue($value);
4141
$this->setValue($value);
@@ -45,5 +45,5 @@ public function beforeSave()
4545
$value = $this->getValue();
4646
$value = $this->fieldProcessor->buildStorableArrayFieldValue($value);
4747
$this->setValue($value);
48-
}
48+
}
4949
}

0 commit comments

Comments
 (0)