Fix tflint

Author: snemetz

.tflint.hcl

@@ -2,6 +2,7 @@ config {
 terraform_version = "0.11.10"
 deep_check = true
 ignore_module = {
+"devops-workflow/ecs-service/aws" = true
 }
 }
 

README.md

@@ -23,17 +23,17 @@ module "" {
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| acm\_cert\_domain | Domain name of ACM-managed certificate | string | `*.mgmt.appzen.com` | no |
+| acm\_cert\_domain | Domain name of ACM-managed certificate | string | `` | no |
 | attributes | Suffix name with additional attributes (policy, role, etc.) | list | `<list>` | no |
-| aws\_profile | - | string | `appzen` | no |
+| aws\_profile | - | string | `` | no |
 | delimiter | Delimiter to be used between `name`, `namespaces`, `attributes`, etc. | string | `-` | no |
 | docker\_image | Docker image to use for task | string | `sonatype/nexus3` | no |
 | docker\_memory | Hard limit on memory use for task container (default 256) | string | `2048` | no |
 | docker\_memory\_reservation | Soft limit on memory use for task container (default 128) | string | `2048` | no |
 | ecs\_cluster\_arn | ARN of ECS cluster in which the service will be deployed | string | `` | no |
 | ecs\_desired\_count | Desired number of containers in the task (default 1) | string | `1` | no |
 | ecs\_security\_group\_id | Security group ID of ECS cluster in which the service will be deployed | string | `` | no |
-| environment | Environment (ex: `dev`, `qa`, `stage`, `prod`). (Second or top level namespace. Depending on namespacing options) | string | `MGMT` | no |
+| environment | Environment (ex: `dev`, `qa`, `stage`, `prod`). (Second or top level namespace. Depending on namespacing options) | string | `mgmt` | no |
 | instance\_type | AWS Instance type, if you change, make sure it is compatible with AMI, not all AMIs allow all instance types | string | `t3.medium` | no |
 | key\_name | SSH key name to use | string | `devops-2018-12-04` | no |
 | lb\_enable\_http | Enable HTTP listener in LB (http or https MUST be enabled) | string | `true` | no |
@@ -44,8 +44,8 @@ module "" {
 | lb\_subnet\_ids | VPC subnet IDs in which to create the LB (unnecessary if neither lb_enable_https or lb_enable_http are true) | list | `<list>` | no |
 | mount\_point | Host directory to map as /nexus-data in container | string | `` | no |
 | name | Base name for resources | string | `nexus` | no |
-| namespace-env | Prefix name with the environment. If true, format is: <env>-<name> | string | `true` | no |
-| namespace-org | Prefix name with the organization. If true, format is: <org>-<env namespaced name>. If both env and org namespaces are used, format will be <org>-<env>-<name> | string | `false` | no |
+| namespace-env | Prefix name with the environment. If true, format is: {env}-{name} | string | `true` | no |
+| namespace-org | Prefix name with the organization. If true, format is: {org}-{env namespaced name}. If both env and org namespaces are used, format will be <org>-<env>-<name> | string | `false` | no |
 | organization | Organization name (Top level namespace). | string | `appzen` | no |
 | region | - | string | `us-east-1` | no |
 | tags | A map of additional tags | map | `<map>` | no |

examples/cluster/README.md

@@ -33,8 +33,8 @@ Note that this example may create resources which cost money. Run `terraform des
 | key\_name | SSH key name to use | string | `devops-2018-12-04` | no |
 | lb\_ingress\_cidr\_blocks | CIDR block to whitelist for the load balancer | list | `<list>` | no |
 | name | Base name for resources | string | `nexus` | no |
-| namespace-env | Prefix name with the environment. If true, format is: <env>-<name> | string | `true` | no |
-| namespace-org | Prefix name with the organization. If true, format is: <org>-<env namespaced name>. If both env and org namespaces are used, format will be <org>-<env>-<name> | string | `false` | no |
+| namespace-env | Prefix name with the environment. If true, format is: {env}-{name} | string | `true` | no |
+| namespace-org | Prefix name with the organization. If true, format is: {org}-{env namespaced name}. If both env and org namespaces are used, format will be <org>-<env>-<name> | string | `false` | no |
 | organization | Organization name (Top level namespace). | string | `example` | no |
 | region | - | string | `us-east-1` | no |
 | tags | A map of additional tags | map | `<map>` | no |

examples/cluster/variables.tf

@@ -23,12 +23,12 @@ variable "name" {
 }
 
 variable "namespace-env" {
-  description = "Prefix name with the environment. If true, format is: <env>-<name>"
+  description = "Prefix name with the environment. If true, format is: {env}-{name}"
   default     = true
 }
 
 variable "namespace-org" {
-  description = "Prefix name with the organization. If true, format is: <org>-<env namespaced name>. If both env and org namespaces are used, format will be <org>-<env>-<name>"
+  description = "Prefix name with the organization. If true, format is: {org}-{env namespaced name}. If both env and org namespaces are used, format will be <org>-<env>-<name>"
   default     = false
 }
 

variables.tf

@@ -14,7 +14,7 @@ variable "delimiter" {
 
 variable "environment" {
   description = "Environment (ex: `dev`, `qa`, `stage`, `prod`). (Second or top level namespace. Depending on namespacing options)"
-  default     = "MGMT"
+  default     = "mgmt"
 }
 
 variable "name" {
@@ -23,12 +23,12 @@ variable "name" {
 }
 
 variable "namespace-env" {
-  description = "Prefix name with the environment. If true, format is: <env>-<name>"
+  description = "Prefix name with the environment. If true, format is: {env}-{name}"
   default     = true
 }
 
 variable "namespace-org" {
-  description = "Prefix name with the organization. If true, format is: <org>-<env namespaced name>. If both env and org namespaces are used, format will be <org>-<env>-<name>"
+  description = "Prefix name with the organization. If true, format is: {org}-{env namespaced name}. If both env and org namespaces are used, format will be <org>-<env>-<name>"
   default     = false
 }
 
@@ -49,11 +49,11 @@ variable "tags" {
 variable "acm_cert_domain" {
   description = "Domain name of ACM-managed certificate"
   type        = "string"
-  default     = "*.mgmt.appzen.com"
+  default     = ""
 }
 
 variable "aws_profile" {
-  default = "appzen"
+  default = ""
 }
 
 variable "docker_image" {
@@ -122,33 +122,7 @@ variable "lb_internal" {
 variable "lb_ingress_cidr_blocks" {
   description = "CIDR block to whitelist for the load balancer"
   type        = "list"
-
-  default = [
-    # Appzen offices
-    "12.51.198.242/32",  # "0.0.0.0/0",
-
-    "184.183.7.98/32",
-
-    # Bitbucket
-    # "104.192.136.0/21","34.198.203.127","34.198.32.85",
-    # Bitbucket Pipeline build environments
-    "34.199.54.113/32",
-
-    "34.232.25.90/32",
-    "34.232.119.183/32",
-    "34.236.25.177/32",
-    "35.171.175.212/32",
-    "52.54.90.98/32",
-    "52.202.195.162/32",
-    "52.203.14.55/32",
-    "52.204.96.37/32",
-    "34.218.156.209/32",
-    "34.218.168.212/32",
-    "52.41.219.63/32",
-    "35.155.178.254/32",
-    "35.160.177.10/32",
-    "34.216.18.129/32",
-  ]
+  default     = ["0.0.0.0/0"]
 }
 
 variable "lb_subnet_ids" {