Fix site layout #129
Open
Fix site layout #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brandondees
reviewed
Aug 4, 2017
| body { flex-flow: row wrap } | ||
| body > main { margin-left: 20vw; flex-basis: 55vw; max-width: 55vw; } | ||
| body > aside { flex-basis: 25vw } | ||
| body > aside { flex-basis: 24vw } /* This should be 25 WTF? */ |
There was a problem hiding this comment.
is everything border-box? that can add some surprise outer size to things
|
@brandondees https://snuggsi-quuajhsufx.now.sh#installation Can you try to delete main element and see if page snaps into layout? |
|
somehow i forgot to comment on this... i can't get that now.sh to load anymore but when i first tried it it did not address the issue |
|
Modern CSS layouts https://www.youtube.com/watch?v=3Zv_l8FHVs8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
@brandondees please test @ https://snuggsi-hclzusoiyy.now.sh should be launched within next few mins. Here's what i'm getting.