Skip to content

Commit a181ac4

Browse files
committed
finalizing working build
1 parent 93be362 commit a181ac4

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

terraform/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ module "gcp_python_fastapi_pipeline" {
4747
region = var.region
4848

4949
cloudbuild_trigger_name = "gcp-python-fastapi"
50-
service_name = "gcp-python-fastapi-service"
5150
description = "Cloud Build Trigger for GCP Python FastAPI"
5251
github_repo_name = "gcp-python-fastapi"
5352
secret_id = google_secret_manager_secret.snyk_token.secret_id

terraform/modules/pipelines/main.tf

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,6 @@ resource "google_project_iam_member" "cloud_build_roles" {
2121
member = "serviceAccount:${google_service_account.cloudbuild_service_account.email}"
2222
}
2323

24-
resource "google_cloud_run_service_iam_member" "all_users_invoker" {
25-
project = var.project_id
26-
location = var.region
27-
service = var.service_name
28-
29-
role = "roles/run.invoker"
30-
member = "allUsers"
31-
}
32-
3324
resource "google_secret_manager_secret_iam_binding" "secret_manager_binding" {
3425
for_each = toset([
3526
"roles/secretmanager.secretAccessor",

terraform/modules/pipelines/variable.tf

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@ variable "cloudbuild_trigger_name" {
33
type = string
44
}
55

6-
variable "service_name" {
7-
description = "Name of the Cloud Run service"
8-
type = string
9-
}
10-
116
variable "description" {
127
description = "Description of the Cloud Build trigger"
138
type = string

0 commit comments

Comments
 (0)