Skip to content

Commit 39ad80e

Browse files
authored
Merge pull request #320 from 0x41head/teams-evidence
Added teamsEvidence
2 parents 543dc5b + 2e49d65 commit 39ad80e

File tree

4 files changed

+43
-10
lines changed

4 files changed

+43
-10
lines changed

.prettierignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,5 @@ testem.log
4242
# System Files
4343
.DS_Store
4444
Thumbs.db
45+
46+
/src/assets/YAML/generated/generated.yaml

src/app/component/activity-description/activity-description.component.html

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,21 @@ <h1>
8282
<mat-expansion-panel>
8383
<mat-expansion-panel-header>
8484
<mat-panel-title>
85-
<b>Evidence</b>
85+
<b>Teams Evidence</b>
8686
</mat-panel-title>
8787
</mat-expansion-panel-header>
88-
<p id="evidence" [innerHTML]="currentActivity.evidence"></p>
88+
<mat-accordion multi="true">
89+
<mat-expansion-panel
90+
id="teamsEvidence"
91+
*ngFor="let item of this.currentActivity.teamsEvidence | keyvalue">
92+
<mat-expansion-panel-header>
93+
<mat-panel-title>
94+
<b [innerHTML]="item.key"></b>
95+
</mat-panel-title>
96+
</mat-expansion-panel-header>
97+
<p [innerHTML]="item.value"></p>
98+
</mat-expansion-panel>
99+
</mat-accordion>
89100
</mat-expansion-panel>
90101

91102
<mat-expansion-panel>
@@ -153,7 +164,7 @@ <h1>
153164
<b>References</b>
154165
</mat-panel-title>
155166
</mat-expansion-panel-header>
156-
<p>
167+
<p id="references">
157168
<mat-accordion multi="true">
158169
<mat-expansion-panel>
159170
<mat-expansion-panel-header>

src/app/component/activity-description/activity-description.component.spec.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,17 @@ describe('ActivityDescriptionComponent', () => {
9494
});
9595

9696
it('check if evidence is being generated', () => {
97-
const testEvidence = 'Sample Evidence';
98-
component.currentActivity.evidence = testEvidence;
97+
const testEvidence = { A: 'Sample Evidence', Default: 'Sample evidence 2' };
98+
component.currentActivity.teamsEvidence = testEvidence;
9999
fixture.detectChanges();
100100
const HTMLElement: HTMLElement = fixture.nativeElement;
101-
const contentDisplayedinParagraphTag =
102-
HTMLElement.querySelector('#evidence')!;
103-
expect(contentDisplayedinParagraphTag.textContent).toContain(testEvidence);
101+
const parentElement = HTMLElement.querySelectorAll('#teamsEvidence')!;
102+
console.log('parentElement', parentElement[1].textContent);
103+
const lengthOfObject = Object.keys(testEvidence).length;
104+
for (var i = 0; i > lengthOfObject; i++)
105+
expect(parentElement[i].textContent).toContain(
106+
Object.keys(testEvidence)[i] + Object.values(testEvidence)[i]
107+
);
104108
});
105109

106110
it('check if assessment is being generated', () => {
@@ -138,8 +142,10 @@ describe('ActivityDescriptionComponent', () => {
138142

139143
fixture.detectChanges();
140144
const HTMLElement: HTMLElement = fixture.nativeElement;
141-
const contentDisplayedinParagraphTag = HTMLElement.querySelectorAll('p')!;
142-
expect(contentDisplayedinParagraphTag[10].textContent).toContain(
145+
const contentDisplayedinParagraphTag =
146+
HTMLElement.querySelectorAll('#references')!;
147+
148+
expect(contentDisplayedinParagraphTag[0].textContent).toContain(
143149
component.SAMMVersion +
144150
testSAMM[0] +
145151
component.ISOVersion +

src/app/component/activity-description/activity-description.component.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ export interface activityDescription {
3232
implementation: implementation[];
3333
usefulness: number;
3434
evidence: string;
35+
teamsEvidence: Object;
3536
assessment: string;
3637
comments: string;
3738
isImplemented: boolean;
@@ -67,6 +68,7 @@ export class ActivityDescriptionComponent implements OnInit {
6768
usefulness: -1,
6869
assessment: '',
6970
evidence: '',
71+
teamsEvidence: {},
7072
comments: '',
7173
isImplemented: false,
7274
teamsImplemented: {},
@@ -261,6 +263,10 @@ export class ActivityDescriptionComponent implements OnInit {
261263
false
262264
);
263265
this.currentActivity.teamsImplemented = data['teamsImplemented'];
266+
this.currentActivity.teamsEvidence = this.defineEvidenceObject(
267+
data['teamsEvidence']
268+
);
269+
// console.log("data['teamsEvidence']", data['teamsEvidence']);
264270
this.openall();
265271
});
266272
}
@@ -309,6 +315,14 @@ export class ActivityDescriptionComponent implements OnInit {
309315
}
310316
}
311317

318+
defineEvidenceObject(dataToCheck: { [key: string]: string }): Object {
319+
var dataToReturn: { [key: string]: string } = {};
320+
for (var key in dataToCheck) {
321+
dataToReturn[key] = this.defineStringValues(dataToCheck[key], '');
322+
}
323+
return dataToReturn;
324+
}
325+
312326
defineImplementationObject(dataToCheck: implementation[]): implementation[] {
313327
var dataToReturn: implementation[] = [];
314328
for (var data in dataToCheck) {

0 commit comments

Comments
 (0)