Skip to content

fix:validation around pipelineType #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 15, 2024
Merged

fix:validation around pipelineType #1626

merged 10 commits into from
May 15, 2024

Conversation

adi6859
Copy link
Contributor

@adi6859 adi6859 commented Feb 14, 2024

Description

validation for pipeline Type

Fixes devtron-labs/devtron#5118

How Has This Been Tested?

test are performed locally

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Feb 14, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

vivek-devtron
vivek-devtron previously approved these changes Feb 14, 2024
vivek-devtron
vivek-devtron previously approved these changes Apr 17, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adi6859 adi6859 changed the title Bug linked ci fix:validation around pipelineType May 15, 2024
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels May 15, 2024
@adi6859 adi6859 merged commit bda5a3d into main May 15, 2024
11 of 15 checks passed
@adi6859 adi6859 deleted the bug-linked-ci branch May 15, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Validation on Pipeline Type
2 participants