panic recovered go-routines

Author: prkhrkat

client/argocdServer/connection/Connection.go

@@ -21,6 +21,7 @@ import (
 	"fmt"
 	"github.com/argoproj/argo-cd/v2/pkg/apiclient/account"
 	"github.com/argoproj/argo-cd/v2/util/settings"
+	"github.com/devtron-labs/common-lib/async"
 	"github.com/devtron-labs/common-lib/utils/k8s"
 	"github.com/devtron-labs/devtron/client/argocdServer/bean"
 	config2 "github.com/devtron-labs/devtron/client/argocdServer/config"
@@ -81,6 +82,7 @@ type ArgoCDConnectionManagerImpl struct {
 	gitOpsConfigReadService config.GitOpsConfigReadService
 	runTimeConfig           *k8s.RuntimeConfig
 	argoCDConfigGetter      config2.ArgoCDConfigGetter
+	asyncRunnable           *async.Runnable
 }
 
 func NewArgoCDConnectionManagerImpl(Logger *zap.SugaredLogger,
@@ -92,7 +94,8 @@ func NewArgoCDConnectionManagerImpl(Logger *zap.SugaredLogger,
 	versionService version.VersionService,
 	gitOpsConfigReadService config.GitOpsConfigReadService,
 	runTimeConfig *k8s.RuntimeConfig,
-	argoCDConfigGetter config2.ArgoCDConfigGetter) (*ArgoCDConnectionManagerImpl, error) {
+	argoCDConfigGetter config2.ArgoCDConfigGetter,
+	asyncRunnable *async.Runnable) (*ArgoCDConnectionManagerImpl, error) {
 	argoUserServiceImpl := &ArgoCDConnectionManagerImpl{
 		logger:                  Logger,
 		settingsManager:         settingsManager,
@@ -105,13 +108,17 @@ func NewArgoCDConnectionManagerImpl(Logger *zap.SugaredLogger,
 		gitOpsConfigReadService: gitOpsConfigReadService,
 		runTimeConfig:           runTimeConfig,
 		argoCDConfigGetter:      argoCDConfigGetter,
+		asyncRunnable:           asyncRunnable,
 	}
 	if !runTimeConfig.LocalDevMode {
 		grpcConfig, err := argoCDConfigGetter.GetGRPCConfig()
 		if err != nil {
 			Logger.Errorw("error in GetAllGRPCConfigs", "error", err)
 		}
-		go argoUserServiceImpl.ValidateGitOpsAndGetOrUpdateArgoCdUserDetail(grpcConfig)
+		runnableFunc := func() {
+			argoUserServiceImpl.ValidateGitOpsAndGetOrUpdateArgoCdUserDetail(grpcConfig)
+		}
+		asyncRunnable.Execute(runnableFunc)
 	}
 	return argoUserServiceImpl, nil
 }

pkg/build/trigger/HandlerService.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
 	"github.com/caarlos0/env"
+	"github.com/devtron-labs/common-lib/async"
 	blob_storage "github.com/devtron-labs/common-lib/blob-storage"
 	"github.com/devtron-labs/common-lib/utils"
 	bean4 "github.com/devtron-labs/common-lib/utils/bean"
@@ -116,6 +117,7 @@ type HandlerServiceImpl struct {
 	clusterService               cluster.ClusterService
 	envService                   environment.EnvironmentService
 	K8sUtil                      *k8s.K8sServiceImpl
+	asyncRunnable                *async.Runnable
 }
 
 func NewHandlerServiceImpl(Logger *zap.SugaredLogger, workflowService executor.WorkflowService,
@@ -141,6 +143,7 @@ func NewHandlerServiceImpl(Logger *zap.SugaredLogger, workflowService executor.W
 	clusterService cluster.ClusterService,
 	envService environment.EnvironmentService,
 	K8sUtil *k8s.K8sServiceImpl,
+	asyncRunnable *async.Runnable,
 ) *HandlerServiceImpl {
 	buildxCacheFlags := &BuildxCacheFlags{}
 	err := env.Parse(buildxCacheFlags)
@@ -174,6 +177,7 @@ func NewHandlerServiceImpl(Logger *zap.SugaredLogger, workflowService executor.W
 		clusterService:               clusterService,
 		envService:                   envService,
 		K8sUtil:                      K8sUtil,
+		asyncRunnable:                asyncRunnable,
 	}
 	config, err := types.GetCiConfig()
 	if err != nil {
@@ -628,7 +632,12 @@ func (impl *HandlerServiceImpl) triggerCiPipeline(trigger types.Trigger) (int, e
 	}
 
 	middleware.CiTriggerCounter.WithLabelValues(pipeline.App.AppName, pipeline.Name).Inc()
-	go impl.ciService.WriteCITriggerEvent(trigger, pipeline, workflowRequest)
+
+	runnableFunc := func() {
+		impl.ciService.WriteCITriggerEvent(trigger, pipeline, workflowRequest)
+	}
+	impl.asyncRunnable.Execute(runnableFunc)
+
 	return savedCiWf.Id, err
 }
 

pkg/workflow/dag/WorkflowDagExecutor.go

@@ -1050,7 +1050,10 @@ func (impl *WorkflowDagExecutorImpl) HandleCiSuccessEvent(triggerContext trigger
 	} else {
 		ciArtifactArr = append(ciArtifactArr, pluginArtifacts[0])
 	}
-	go impl.WriteCiSuccessEvent(request, pipelineModal, buildArtifact)
+	runnableFunc := func() {
+		impl.WriteCiSuccessEvent(request, pipelineModal, buildArtifact)
+	}
+	impl.asyncRunnable.Execute(runnableFunc)
 	async := false
 
 	// execute auto trigger in batch on CI success event