Revert "feat: plugin creation support (#5630)" (#5778)

This reverts commit 4296366.

Author: prakash100198

api/restHandler/GlobalPluginRestHandler.go

@@ -35,7 +35,6 @@ import (
 
 type GlobalPluginRestHandler interface {
 	PatchPlugin(w http.ResponseWriter, r *http.Request)
-	CreatePlugin(w http.ResponseWriter, r *http.Request)
 
 	GetAllGlobalVariables(w http.ResponseWriter, r *http.Request)
 	ListAllPlugins(w http.ResponseWriter, r *http.Request)
@@ -47,7 +46,6 @@ type GlobalPluginRestHandler interface {
 	GetPluginDetailByIds(w http.ResponseWriter, r *http.Request)
 	GetAllUniqueTags(w http.ResponseWriter, r *http.Request)
 	MigratePluginData(w http.ResponseWriter, r *http.Request)
-	GetAllPluginMinData(w http.ResponseWriter, r *http.Request)
 }
 
 func NewGlobalPluginRestHandler(logger *zap.SugaredLogger, globalPluginService plugin.GlobalPluginService,
@@ -422,68 +420,3 @@ func (handler *GlobalPluginRestHandlerImpl) MigratePluginData(w http.ResponseWri
 	}
 	common.WriteJsonResp(w, nil, nil, http.StatusOK)
 }
-
-func (handler *GlobalPluginRestHandlerImpl) CreatePlugin(w http.ResponseWriter, r *http.Request) {
-	userId, err := handler.userService.GetLoggedInUser(r)
-	if userId == 0 || err != nil {
-		common.WriteJsonResp(w, err, "Unauthorized User", http.StatusUnauthorized)
-		return
-	}
-	token := r.Header.Get("token")
-	appId, err := common.ExtractIntQueryParam(w, r, "appId", 0)
-	if err != nil {
-		return
-	}
-	ok, err := handler.IsUserAuthorized(token, appId)
-	if err != nil {
-		common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
-		return
-	}
-	if !ok {
-		common.WriteJsonResp(w, fmt.Errorf("unauthorized user"), "Unauthorized User", http.StatusForbidden)
-		return
-	}
-	decoder := json.NewDecoder(r.Body)
-	var pluginDataDto bean.PluginParentMetadataDto
-	err = decoder.Decode(&pluginDataDto)
-	if err != nil {
-		handler.logger.Errorw("request err, CreatePlugin", "error", err, "payload", pluginDataDto)
-		common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
-		return
-	}
-	handler.logger.Infow("request payload received for creating plugins", pluginDataDto, "userId", userId)
-
-	pluginVersionId, err := handler.globalPluginService.CreatePluginOrVersions(&pluginDataDto, userId)
-	if err != nil {
-		handler.logger.Errorw("service error, error in creating plugin", "pluginCreateRequestDto", pluginDataDto, "err", err)
-		common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
-		return
-	}
-
-	common.WriteJsonResp(w, nil, bean.NewPluginMinDto().WithPluginVersionId(pluginVersionId), http.StatusOK)
-}
-
-func (handler *GlobalPluginRestHandlerImpl) GetAllPluginMinData(w http.ResponseWriter, r *http.Request) {
-	token := r.Header.Get("token")
-	appId, err := common.ExtractIntQueryParam(w, r, "appId", 0)
-	if err != nil {
-		return
-	}
-	ok, err := handler.IsUserAuthorized(token, appId)
-	if err != nil {
-		common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
-		return
-	}
-	if !ok {
-		common.WriteJsonResp(w, fmt.Errorf("unauthorized user"), "Unauthorized User", http.StatusForbidden)
-		return
-	}
-
-	pluginDetail, err := handler.globalPluginService.GetAllPluginMinData()
-	if err != nil {
-		handler.logger.Errorw("error in getting all unique tags", "err", err)
-		common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
-		return
-	}
-	common.WriteJsonResp(w, nil, pluginDetail, http.StatusOK)
-}

api/router/GlobalPluginRouter.go

@@ -41,8 +41,7 @@ type GlobalPluginRouterImpl struct {
 func (impl *GlobalPluginRouterImpl) initGlobalPluginRouter(globalPluginRouter *mux.Router) {
 	globalPluginRouter.Path("/migrate").
 		HandlerFunc(impl.globalPluginRestHandler.MigratePluginData).Methods("PUT")
-	globalPluginRouter.Path("/create").
-		HandlerFunc(impl.globalPluginRestHandler.CreatePlugin).Methods("POST")
+
 	// versioning impact handling to be done for below apis,
 	globalPluginRouter.Path("").
 		HandlerFunc(impl.globalPluginRestHandler.PatchPlugin).Methods("POST")
@@ -69,7 +68,5 @@ func (impl *GlobalPluginRouterImpl) initGlobalPluginRouter(globalPluginRouter *m
 
 	globalPluginRouter.Path("/list/tags").
 		HandlerFunc(impl.globalPluginRestHandler.GetAllUniqueTags).Methods("GET")
-	globalPluginRouter.Path("/list/v2/min").
-		HandlerFunc(impl.globalPluginRestHandler.GetAllPluginMinData).Methods("GET")
 
 }

internal/util/ErrorUtil.go

@@ -26,7 +26,6 @@ import (
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
 	"net/http"
-	"strconv"
 )
 
 type ApiError struct {
@@ -37,14 +36,6 @@ type ApiError struct {
 	UserDetailMessage string      `json:"userDetailMessage,omitempty"`
 }
 
-func GetApiError(code int, userMessage, internalMessage string) *ApiError {
-	return &ApiError{
-		HttpStatusCode:  code,
-		Code:            strconv.Itoa(code),
-		InternalMessage: internalMessage,
-		UserMessage:     userMessage,
-	}
-}
 func NewApiError() *ApiError {
 	return &ApiError{}
 }