Skip to content

Commit 488f955

Browse files
authored
fix: chartRef fetch in historical deployment triggers (#4654)
1 parent 977690b commit 488f955

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

internal/sql/repository/DeploymentTemplateRepository.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ func (impl DeploymentTemplateRepositoryImpl) FetchDeploymentHistoryWithChartRefs
5353
limit := 15
5454

5555
query := "select p.id as pipeline_id, dth.id as deployment_template_history_id," +
56-
" wfr.finished_on, wfr.status, ceco.chart_id, c.chart_version FROM cd_workflow_runner wfr" +
56+
" wfr.finished_on, wfr.status, c.chart_ref_id, c.chart_version FROM cd_workflow_runner wfr" +
5757
" JOIN cd_workflow wf ON wf.id = wfr.cd_workflow_id JOIN pipeline p ON p.id = wf.pipeline_id" +
5858
" JOIN deployment_template_history dth ON dth.deployed_on = wfr.started_on " +
5959
"JOIN pipeline_config_override pco ON pco.cd_workflow_id = wf.id " +

pkg/pipeline/WorkflowDagExecutor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3852,7 +3852,7 @@ func (impl *WorkflowDagExecutorImpl) GetEnvOverrideByTriggerType(overrideRequest
38523852
}
38533853
//getting chart_ref by id
38543854
_, span = otel.Tracer("orchestrator").Start(ctx, "chartRefRepository.FindByVersionAndName")
3855-
chartRefDto, err := impl.chartRefService.FindByVersionAndName(templateName, templateVersion)
3855+
chartRefDto, err := impl.chartRefService.FindByVersionAndName(templateVersion, templateName)
38563856
span.End()
38573857
if err != nil {
38583858
impl.logger.Errorw("error in getting chartRef by version and name", "err", err, "version", templateVersion, "name", templateName)

0 commit comments

Comments
 (0)