Skip to content

Commit 4f04d6b

Browse files
refrain from checkin autoscalingCheckBeforeTrigger for virt clus (#5696)
1 parent 779e913 commit 4f04d6b

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

pkg/deployment/manifest/ManifestCreationService.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,10 +275,12 @@ func (impl *ManifestCreationServiceImpl) GetValuesOverrideForTrigger(overrideReq
275275
// error is not returned as it's not blocking for deployment process
276276
// blocking deployments based on this use case can vary for user to user
277277
}
278-
mergedValues, err = impl.autoscalingCheckBeforeTrigger(newCtx, appName, envOverride.Namespace, mergedValues, overrideRequest)
279-
if err != nil {
280-
impl.logger.Errorw("error in autoscaling check before trigger", "pipelineId", overrideRequest.PipelineId, "err", err)
281-
return valuesOverrideResponse, err
278+
if !envOverride.Environment.IsVirtualEnvironment {
279+
mergedValues, err = impl.autoscalingCheckBeforeTrigger(newCtx, appName, envOverride.Namespace, mergedValues, overrideRequest)
280+
if err != nil {
281+
impl.logger.Errorw("error in autoscaling check before trigger", "pipelineId", overrideRequest.PipelineId, "err", err)
282+
return valuesOverrideResponse, err
283+
}
282284
}
283285
// handle image pull secret if access given
284286
mergedValues, err = impl.dockerRegistryIpsConfigService.HandleImagePullSecretOnApplicationDeployment(newCtx, envOverride.Environment, artifact, pipeline.CiPipelineId, mergedValues)

0 commit comments

Comments
 (0)