fix: plugin getByName method error handling (#6016)

kartik-579 · web-flow · commit 78709a36f129 · 2024-10-24T12:16:07.000+05:30
* plugin fix

* reverted errnorows change
diff --git a/pkg/plugin/GlobalPluginService.go b/pkg/plugin/GlobalPluginService.go
@@ -389,7 +389,7 @@ func (impl *GlobalPluginServiceImpl) GetRefPluginIdByRefPluginName(pluginName st
 		impl.logger.Errorw("error in fetching plugin metadata by name", "err", err)
 		return nil, err
 	}
-	if pluginMetadata == nil {
+	if len(pluginMetadata) == 0 {
 		return nil, nil
 	}
 	pluginVersionDetail = make([]bean2.PluginsVersionDetail, 0)

Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,7 @@ func (impl *GlobalPluginServiceImpl) GetRefPluginIdByRefPluginName(pluginName st`
`389`	`389`	`impl.logger.Errorw("error in fetching plugin metadata by name", "err", err)`
`390`	`390`	`return nil, err`
`391`	`391`	`}`
`392`		`- if pluginMetadata == nil {`
	`392`	`+ if len(pluginMetadata) == 0 {`
`393`	`393`	`return nil, nil`
`394`	`394`	`}`
`395`	`395`	`pluginVersionDetail = make([]bean2.PluginsVersionDetail, 0)`