Skip to content

Commit 8de2c68

Browse files
authored
removed deployment group validation when deleting CD pipelines (#5989)
1 parent 4367f49 commit 8de2c68

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

pkg/pipeline/DeploymentPipelineConfigService.go

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -708,19 +708,6 @@ func (impl *CdPipelineConfigServiceImpl) DeleteCdPipeline(pipeline *pipelineConf
708708
return deleteResponse, err
709709
}
710710

711-
//getting deployment group for this pipeline
712-
deploymentGroupNames, err := impl.deploymentGroupRepository.GetNamesByAppIdAndEnvId(pipeline.EnvironmentId, pipeline.AppId)
713-
if err != nil && err != pg.ErrNoRows {
714-
impl.logger.Errorw("error in getting deployment group names by appId and envId", "err", err)
715-
return deleteResponse, err
716-
} else if len(deploymentGroupNames) > 0 {
717-
groupNamesByte, err := json.Marshal(deploymentGroupNames)
718-
if err != nil {
719-
impl.logger.Errorw("error in marshaling deployment group names", "err", err, "deploymentGroupNames", deploymentGroupNames)
720-
}
721-
impl.logger.Debugw("cannot delete cd pipeline, is being used in deployment group")
722-
return deleteResponse, fmt.Errorf("Please remove this CD pipeline from deployment groups : %s", string(groupNamesByte))
723-
}
724711
dbConnection := impl.pipelineRepository.GetConnection()
725712
tx, err := dbConnection.Begin()
726713
if err != nil {
@@ -2034,19 +2021,6 @@ func (impl *CdPipelineConfigServiceImpl) DeleteCdPipelinePartial(pipeline *pipel
20342021
return deleteResponse, err
20352022
}
20362023

2037-
//getting deployment group for this pipeline
2038-
deploymentGroupNames, err := impl.deploymentGroupRepository.GetNamesByAppIdAndEnvId(pipeline.EnvironmentId, pipeline.AppId)
2039-
if err != nil && err != pg.ErrNoRows {
2040-
impl.logger.Errorw("error in getting deployment group names by appId and envId", "err", err)
2041-
return deleteResponse, err
2042-
} else if len(deploymentGroupNames) > 0 {
2043-
groupNamesByte, err := json.Marshal(deploymentGroupNames)
2044-
if err != nil {
2045-
impl.logger.Errorw("error in marshaling deployment group names", "err", err, "deploymentGroupNames", deploymentGroupNames)
2046-
}
2047-
impl.logger.Debugw("cannot delete cd pipeline, is being used in deployment group")
2048-
return deleteResponse, fmt.Errorf("Please remove this CD pipeline from deployment groups : %s", string(groupNamesByte))
2049-
}
20502024
dbConnection := impl.pipelineRepository.GetConnection()
20512025
tx, err := dbConnection.Begin()
20522026
if err != nil {

0 commit comments

Comments
 (0)