Skip to content

Commit 9893998

Browse files
authored
adding service account in chart sync (#5584)
1 parent 08429e0 commit 9893998

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

pkg/chartRepo/ChartRepositoryService.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,7 @@ func (impl *ChartRepositoryServiceImpl) TriggerChartSyncManual(chartProviderConf
725725

726726
defaultClusterConfig := defaultClusterBean.GetClusterConfig()
727727

728-
manualAppSyncJobByteArr := manualAppSyncJobByteArr(impl.serverEnvConfig.AppSyncImage, impl.serverEnvConfig.AppSyncJobResourcesObj, chartProviderConfig)
728+
manualAppSyncJobByteArr := manualAppSyncJobByteArr(impl.serverEnvConfig.AppSyncImage, impl.serverEnvConfig.AppSyncJobResourcesObj, impl.serverEnvConfig.AppSyncServiceAccount, chartProviderConfig)
729729
err = impl.K8sUtil.DeleteAndCreateJob(manualAppSyncJobByteArr, impl.aCDAuthConfig.ACDConfigMapNamespace, defaultClusterConfig)
730730
if err != nil {
731731
impl.logger.Errorw("DeleteAndCreateJob err, TriggerChartSyncManual", "err", err)

pkg/chartRepo/ManualAppSyncYaml.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,22 @@ type AppSyncConfig struct {
2727
DockerImage string
2828
AppSyncJobResourcesObj string
2929
ChartProviderConfig *ChartProviderConfig
30+
AppSyncServiceAccount string
3031
}
3132

3233
type ChartProviderConfig struct {
3334
ChartProviderId string
3435
IsOCIRegistry bool
3536
}
3637

37-
func manualAppSyncJobByteArr(dockerImage string, appSyncJobResourcesObj string, chartProviderConfig *ChartProviderConfig) []byte {
38+
func manualAppSyncJobByteArr(dockerImage string, appSyncJobResourcesObj string, appSyncServiceAccount string, chartProviderConfig *ChartProviderConfig) []byte {
3839
cfg, _ := sql.GetConfig()
3940
configValues := AppSyncConfig{
4041
DbConfig: sql.Config{Addr: cfg.Addr, Database: cfg.Database, User: cfg.User, Password: cfg.Password},
4142
DockerImage: dockerImage,
4243
AppSyncJobResourcesObj: appSyncJobResourcesObj,
4344
ChartProviderConfig: chartProviderConfig,
45+
AppSyncServiceAccount: appSyncServiceAccount,
4446
}
4547
temp := template.New("manualAppSyncJobByteArr")
4648
temp, _ = temp.Parse(`{"apiVersion": "batch/v1",
@@ -52,6 +54,7 @@ func manualAppSyncJobByteArr(dockerImage string, appSyncJobResourcesObj string,
5254
"spec": {
5355
"template": {
5456
"spec": {
57+
"serviceAccount": "{{.AppSyncServiceAccount}}",
5558
"containers": [
5659
{
5760
"name": "chart-sync",

pkg/server/config/ServerEnvConfig.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ type ServerEnvConfig struct {
3636
DevtronModulesIdentifierInHelmValues string `env:"DEVTRON_MODULES_IDENTIFIER_IN_HELM_VALUES" envDefault:"installer.modules"`
3737
DevtronBomUrl string `env:"DEVTRON_BOM_URL" envDefault:"https://raw.githubusercontent.com/devtron-labs/devtron/%s/charts/devtron/devtron-bom.yaml"`
3838
AppSyncImage string `env:"APP_SYNC_IMAGE" envDefault:"quay.io/devtron/chart-sync:1227622d-132-3775"`
39+
AppSyncServiceAccount string `env:"APP_SYNC_SERVICE_ACCOUNT" envDefault:"chart-sync"`
3940
AppSyncJobResourcesObj string `env:"APP_SYNC_JOB_RESOURCES_OBJ"`
4041
ModuleMetaDataApiUrl string `env:"MODULE_METADATA_API_URL" envDefault:"https://api.devtron.ai/module?name=%s"`
4142
}

0 commit comments

Comments
 (0)