fix: external helm app when linked to devtron and page breaks while adding project to it, without switching back to applist (#5443)

* checking if app exist for a app identifier, if yes then don't craete new installed app entry

* nil check

Author: prakash100198

pkg/appStore/installedApp/service/EAMode/InstalledAppDBService.go

@@ -372,6 +372,17 @@ func (impl *InstalledAppDBServiceImpl) CreateNewAppEntryForAllInstalledApps(inst
 	// Rollback tx on error.
 	defer tx.Rollback()
 	for _, installedApp := range installedApps {
+		//check if for this unique identifier name an app already exists, if yes then continue
+		appMetadata, err := impl.AppRepository.FindActiveByName(installedApp.GetUniqueAppNameIdentifier())
+		if err != nil && !util.IsErrNoRows(err) {
+			impl.Logger.Errorw("error in fetching app by unique app identifier", "appNameUniqueIdentifier", installedApp.GetUniqueAppNameIdentifier(), "err", err)
+			return err
+		}
+		if appMetadata != nil && appMetadata.Id > 0 {
+			//app already exists for this unique identifier hence not creating new app entry for this
+			continue
+		}
+
 		appModel := &app.App{
 			Active:          true,
 			AppName:         installedApp.GetUniqueAppNameIdentifier(),
@@ -381,7 +392,7 @@ func (impl *InstalledAppDBServiceImpl) CreateNewAppEntryForAllInstalledApps(inst
 			DisplayName:     installedApp.App.AppName,
 		}
 		appModel.CreateAuditLog(bean3.SystemUserId)
-		err := impl.AppRepository.SaveWithTxn(appModel, tx)
+		err = impl.AppRepository.SaveWithTxn(appModel, tx)
 		if err != nil {
 			impl.Logger.Errorw("error saving appModel", "err", err)
 			return err