Skip to content

Commit c6f9555

Browse files
committed
summarycron expr change
1 parent ee71147 commit c6f9555

File tree

6 files changed

+13
-8
lines changed

6 files changed

+13
-8
lines changed

client/telemetry/PosthogClient.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ type PosthogClient struct {
3636
var (
3737
PosthogApiKey string = ""
3838
PosthogEndpoint string = "https://app.posthog.com"
39-
SummaryCronExpr string = "0 0 * * *" // Run once a day, midnight
4039
HeartbeatCronExpr string = "0 0/6 * * *"
4140
CacheExpiry int = 1440
4241
PosthogEncodedApiKey string = ""

client/telemetry/TelemetryEventClient.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func NewTelemetryEventClientImpl(logger *zap.SugaredLogger, client *http.Client,
7575
K8sUtil *k8s.K8sServiceImpl, aCDAuthConfig *util3.ACDAuthConfig, userService user2.UserService,
7676
attributeRepo repository.AttributesRepository, ssoLoginService sso.SSOLoginService,
7777
PosthogClient *PosthogClient, moduleRepository moduleRepo.ModuleRepository, serverDataStore *serverDataStore.ServerDataStore, userAuditService user2.UserAuditService, helmAppClient gRPC.HelmAppClient, InstalledAppRepository repository2.InstalledAppRepository,
78-
cloudProviderIdentifierService cloudProviderIdentifier.ProviderIdentifierService, cronLogger *cron3.CronLoggerImpl) (*TelemetryEventClientImpl, error) {
78+
cloudProviderIdentifierService cloudProviderIdentifier.ProviderIdentifierService, cronLogger *cron3.CronLoggerImpl, envVariables *util.EnvironmentVariables) (*TelemetryEventClientImpl, error) {
7979
cron := cron.New(
8080
cron.WithChain(cron.Recover(cronLogger)))
8181
cron.Start()
@@ -97,6 +97,7 @@ func NewTelemetryEventClientImpl(logger *zap.SugaredLogger, client *http.Client,
9797
}
9898

9999
watcher.HeartbeatEventForTelemetry()
100+
SummaryCronExpr := envVariables.PostHogClientConfig.SummaryCron
100101
_, err := cron.AddFunc(SummaryCronExpr, watcher.SummaryEventForTelemetryEA)
101102
if err != nil {
102103
logger.Errorw("error in starting summery event", "err", err)

client/telemetry/TelemetryEventClientExtended.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func NewTelemetryEventClientImplExtended(logger *zap.SugaredLogger, client *http
6464
ciBuildConfigService pipeline.CiBuildConfigService, moduleRepository moduleRepo.ModuleRepository, serverDataStore *serverDataStore.ServerDataStore,
6565
helmAppClient client.HelmAppClient, InstalledAppRepository repository2.InstalledAppRepository, userAttributesRepository repository.UserAttributesRepository,
6666
cloudProviderIdentifierService cloudProviderIdentifier.ProviderIdentifierService, cronLogger *cron3.CronLoggerImpl,
67-
gitOpsConfigReadService config.GitOpsConfigReadService) (*TelemetryEventClientImplExtended, error) {
67+
gitOpsConfigReadService config.GitOpsConfigReadService, envVariables *util.EnvironmentVariables) (*TelemetryEventClientImplExtended, error) {
6868

6969
cron := cron.New(
7070
cron.WithChain(cron.Recover(cronLogger)))
@@ -107,6 +107,7 @@ func NewTelemetryEventClientImplExtended(logger *zap.SugaredLogger, client *http
107107
}
108108

109109
watcher.HeartbeatEventForTelemetry()
110+
SummaryCronExpr := envVariables.PostHogClientConfig.SummaryCron
110111
_, err := cron.AddFunc(SummaryCronExpr, watcher.SummaryEventForTelemetry)
111112
if err != nil {
112113
logger.Errorw("error in starting summery event", "err", err)

cmd/external-app/wire_gen.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

util/GlobalConfig.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,11 @@ type EnvironmentVariables struct {
88
GlobalEnvVariables *GlobalEnvVariables
99
DevtronSecretConfig *DevtronSecretConfig
1010
DeploymentServiceTypeConfig *DeploymentServiceTypeConfig
11+
PostHogClientConfig *PostHogClientConfig
12+
}
13+
type PostHogClientConfig struct {
14+
SummaryCron string `env:"POSTHOG_SUMMARY_CRON_EXPR" envDefault:"0 0 * * *"` // Default Run once a day, midnight
1115
}
12-
1316
type DeploymentServiceTypeConfig struct {
1417
ExternallyManagedDeploymentType bool `env:"IS_INTERNAL_USE" envDefault:"false"`
1518
HelmInstallASyncMode bool `env:"RUN_HELM_INSTALL_IN_ASYNC_MODE_HELM_APPS" envDefault:"false"`
@@ -31,6 +34,7 @@ func GetEnvironmentVariables() (*EnvironmentVariables, error) {
3134
GlobalEnvVariables: &GlobalEnvVariables{},
3235
DevtronSecretConfig: &DevtronSecretConfig{},
3336
DeploymentServiceTypeConfig: &DeploymentServiceTypeConfig{},
37+
PostHogClientConfig: &PostHogClientConfig{},
3438
}
3539
err := env.Parse(cfg)
3640
if err != nil {

wire_gen.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)