comment

prakash100198 · prakash100198 · commit e37dbb7da7f2 · 2024-08-20T12:09:47.000+05:30
diff --git a/pkg/pipeline/ConfigMapService.go b/pkg/pipeline/ConfigMapService.go
@@ -506,6 +506,7 @@ func (impl ConfigMapServiceImpl) CSGlobalAddUpdate(configMapRequest *bean.Config
 		return nil, fmt.Errorf("invalid request multiple config found for add or update")
 	}
 	configData := configMapRequest.ConfigData[0]
+	// validating config/secret data at service layer since this func is consumed in multiple flows, hence preventing code duplication
 	valid, err := impl.validateConfigData(configData)
 	if err != nil && !valid {
 		impl.logger.Errorw("error in validating", "error", err)
@@ -712,6 +713,7 @@ func (impl ConfigMapServiceImpl) CSEnvironmentAddUpdate(configMapRequest *bean.C
 	}
 
 	configData := configMapRequest.ConfigData[0]
+	// validating config/secret data at service layer since this func is consumed in multiple flows, hence preventing code duplication
 	valid, err := impl.validateConfigData(configData)
 	if err != nil && !valid {
 		impl.logger.Errorw("error in validating", "error", err)

Original file line number	Diff line number	Diff line change
`@@ -506,6 +506,7 @@ func (impl ConfigMapServiceImpl) CSGlobalAddUpdate(configMapRequest *bean.Config`
`506`	`506`	`return nil, fmt.Errorf("invalid request multiple config found for add or update")`
`507`	`507`	`}`
`508`	`508`	`configData := configMapRequest.ConfigData[0]`
	`509`	`+ // validating config/secret data at service layer since this func is consumed in multiple flows, hence preventing code duplication`
`509`	`510`	`valid, err := impl.validateConfigData(configData)`
`510`	`511`	`if err != nil && !valid {`
`511`	`512`	`impl.logger.Errorw("error in validating", "error", err)`
`@@ -712,6 +713,7 @@ func (impl ConfigMapServiceImpl) CSEnvironmentAddUpdate(configMapRequest *bean.C`
`712`	`713`	`}`
`713`	`714`
`714`	`715`	`configData := configMapRequest.ConfigData[0]`
	`716`	`+ // validating config/secret data at service layer since this func is consumed in multiple flows, hence preventing code duplication`
`715`	`717`	`valid, err := impl.validateConfigData(configData)`
`716`	`718`	`if err != nil && !valid {`
`717`	`719`	`impl.logger.Errorw("error in validating", "error", err)`