Skip to content

Commit fcae94f

Browse files
authored
default PipelineType given (#5668)
1 parent a43cbfa commit fcae94f

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

pkg/pipeline/BuildPipelineConfigService.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,16 @@ func (impl *CiPipelineConfigServiceImpl) patchCiPipelineUpdateSource(baseCiConfi
285285
impl.logger.Errorw("error in fetching pipeline", "id", modifiedCiPipeline.Id, "err", err)
286286
return nil, err
287287
}
288+
// updating PipelineType from db if not present in request
289+
if modifiedCiPipeline.PipelineType == "" {
290+
if CiPipeline.PipelineType(pipeline.PipelineType) != "" {
291+
modifiedCiPipeline.PipelineType = CiPipeline.PipelineType(pipeline.PipelineType)
292+
} else {
293+
// updating default pipelineType if not present in request
294+
modifiedCiPipeline.PipelineType = CiPipeline.DefaultPipelineType
295+
296+
}
297+
}
288298
if !modifiedCiPipeline.PipelineType.IsValidPipelineType() {
289299
impl.logger.Debugw(" Invalid PipelineType", "PipelineType", modifiedCiPipeline.PipelineType)
290300
errorMessage := fmt.Sprintf(CiPipeline.PIPELINE_TYPE_IS_NOT_VALID, modifiedCiPipeline.Name)

pkg/pipeline/bean/CiPipeline/CiBuildConfig.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ const PIPELINE_TYPE_IS_NOT_VALID = "PipelineType is not valid for pipeline %s"
3232

3333
type PipelineType string
3434

35+
// default PipelineType
36+
const DefaultPipelineType = CI_BUILD
37+
3538
const (
3639
CI_BUILD PipelineType = "CI_BUILD"
3740
LINKED PipelineType = "LINKED"

0 commit comments

Comments
 (0)