fix: [Prod]Git account breaking whenever opening an existing account git repo. #4117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishdevtron
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
ashishdevtron
requested review from
prakarsh-dt,
ashokdevtron and
uxarya-d
as code owners
kartik-579
requested changes
Oct 19, 2023
pkg/pipeline/GitRegistryConfig.go
Outdated
| impl.logger.Debug("fetch disabled git provider by ID from db") | ||
| provider, err := impl.gitProviderRepo.FindDisabledById(providerId) | ||
| if err != nil { | ||
| impl.logger.Errorw("error in fetching disabled git providers", "err", err) |
| //RBAC | ||
| res, err := handler.gitRegistryConfig.FetchOneDisabledGitProvider(providerId) | ||
| if err != nil { | ||
| handler.Logger.Errorw("service err, DisabledGitListAutocomplete", "err", err, "appId", appId) |
|
Kudos, SonarCloud Quality Gate passed!
|
kartik-579
previously approved these changes
Oct 19, 2023
ashishdevtron
dismissed
kartik-579’s stale review
The base branch was changed.
|
Not required anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposed an API to fetch disabled git providers by ID
Fixes # https://dev.azure.com/DevtronLabs/Devtron/_workitems/edit/6200
How Has This Been Tested?
Checklist:
Does this PR introduce a user-facing change?