fix: old pods are listed in new pod section for devtron apps deployed through Helm #4165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishdevtron
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
kartik-579
requested changes
Oct 27, 2023
| podMetadata := resourceTree["podMetadata"] | ||
| for _, data := range podMetadata.([]interface{}) { | ||
| dataMap := data.(map[string]interface{}) | ||
| if _, ok := dataMap["isNew"]; !ok { |
| @@ -1594,6 +1594,14 @@ func (handler AppListingRestHandlerImpl) fetchResourceTree(w http.ResponseWriter | |||
| } | |||
| if detail != nil && detail.ReleaseExist { | |||
| resourceTree = util2.InterfaceToMapAdapter(detail.ResourceTreeResponse) | |||
| // add "isNew = false" flag in podMetaData - isNew flag will be omitted when the value is false | |||
| podMetadata := resourceTree["podMetadata"] | |||
| @@ -1594,6 +1594,14 @@ func (handler AppListingRestHandlerImpl) fetchResourceTree(w http.ResponseWriter | |||
| } | |||
| if detail != nil && detail.ReleaseExist { | |||
| resourceTree = util2.InterfaceToMapAdapter(detail.ResourceTreeResponse) | |||
| // add "isNew = false" flag in podMetaData - isNew flag will be omitted when the value is false | |||
| podMetadata := resourceTree["podMetadata"] | |||
| for _, data := range podMetadata.([]interface{}) { | |||
There was a problem hiding this comment.
is this type assertion always going to work? should add a validation for this
| // add "isNew = false" flag in podMetaData - isNew flag will be omitted when the value is false | ||
| podMetadata := resourceTree["podMetadata"] | ||
| for _, data := range podMetadata.([]interface{}) { | ||
| dataMap := data.(map[string]interface{}) |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Outdated, Not required anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes fix the flag condition which decides whether the pods are new or old
Fixes #4024
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?