-
Notifications
You must be signed in to change notification settings - Fork 531
feat:wire nil test in pre ci pipeline #4858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10190659 | Triggered | Generic High Entropy Secret | 910d88f | wireNil.env | View secret |
10190659 | Triggered | Generic High Entropy Secret | 1102b85 | wireNil.env | View secret |
10190659 | Triggered | Generic High Entropy Secret | 04dafc1 | wireNil.env | View secret |
10190659 | Triggered | Generic High Entropy Secret | 1df34c6 | wireNil.env | View secret |
10190660 | Triggered | Generic Password | 910d88f | tests/integrationTesting/devtron-secret.yaml | View secret |
10190660 | Triggered | Generic Password | 04dafc1 | tests/integrationTesting/devtron-secret.yaml | View secret |
10190661 | Triggered | Generic Password | 910d88f | wireNil.env | View secret |
10190661 | Triggered | Generic Password | 04dafc1 | wireNil.env | View secret |
10220829 | Triggered | Generic High Entropy Secret | 92fe5b4 | charts/devtron/values.yaml | View secret |
10220829 | Triggered | Generic High Entropy Secret | 92fe5b4 | charts/devtron/devtron-bom.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
# # | ||
################################# | ||
|
||
- name: reloader |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
# # | ||
############################## | ||
|
||
- name: metrics |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
|
||
app.kubernetes.io/name: nats | ||
app.kubernetes.io/instance: devtron-nats | ||
spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods Medium test
################# | ||
terminationGracePeriodSeconds: 120 | ||
containers: | ||
- name: nats |
Check warning
Code scanning / SonarCloud
CPU limits should be enforced Medium test
# # | ||
################################# | ||
|
||
- name: reloader |
Check warning
Code scanning / SonarCloud
CPU limits should be enforced Medium test
# # | ||
############################## | ||
|
||
- name: metrics |
Check warning
Code scanning / SonarCloud
CPU limits should be enforced Medium test
################# | ||
terminationGracePeriodSeconds: 120 | ||
containers: | ||
- name: nats |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
PR is not linked to any issue, please make the corresponding changes in the body. |
|
Description
Created the 'wireNilCheck' function to identify nil fields within data. Scripts were devised to run this function within a Docker container, facilitating its integration into our Continuous Integration (CI) pipeline without port forwarding. This allows us to validate data integrity early in the process, ensuring that any nil fields are caught and handled appropriately to prevent pipeline failure during pre-CI checks.
Fixes #5144
Checklist:
Does this PR introduce a user-facing change?