fix: fix for gitops repo url configured in argocd and stored in db are out of sync, then 3 commits are being done #4912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/appStore/installedApp/service/AppStoreDeploymentService.go
prakash100198
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
Ash-exp
previously approved these changes
Apr 12, 2024
nishant-d
previously approved these changes
Apr 19, 2024
|
nishant-d
approved these changes
Apr 19, 2024
prakash100198
changed the title
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
komalreddy3
pushed a commit
that referenced
this pull request
May 28, 2024
…e out of sync, then 3 commits are being done (#4912) * handle gitops error case for monorepo migration * fixes * code review changes * code review changes- II * nil check for argoApplication and it's child for panic handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4979
Checklist:
Does this PR introduce a user-facing change?