Skip to content

fix: release not found alert #4928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2024
Merged

fix: release not found alert #4928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68474c6
fix for release not found in argo
iamayushm Apr 9, 2024
867f7be
Merge branch 'main' into release-not-found-issue
iamayushm Apr 10, 2024
85804e9
Merge branch 'main' into release-not-found-issue
iamayushm Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/deployment/trigger/devtronApps/TriggerService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ func (impl *TriggerServiceImpl) deployArgocdApp(overrideRequest *bean3.ValuesOve
impl.logger.Debugw("argocd application created", "name", name)

_, span = otel.Tracer("orchestrator").Start(ctx, "updateArgoPipeline")
updateAppInArgocd, err := impl.updateArgoPipeline(valuesOverrideResponse.Pipeline, valuesOverrideResponse.EnvOverride, ctx)
updateAppInArgocd, err := impl.updateArgoPipeline(ctx, valuesOverrideResponse.Pipeline, valuesOverrideResponse.EnvOverride)
span.End()
if err != nil {
impl.logger.Errorw("error in updating argocd app ", "err", err)
Expand Down Expand Up @@ -1068,13 +1068,13 @@ func (impl *TriggerServiceImpl) deployArgocdApp(overrideRequest *bean3.ValuesOve
}

// update repoUrl, revision and argo app sync mode (auto/manual) if needed
func (impl *TriggerServiceImpl) updateArgoPipeline(pipeline *pipelineConfig.Pipeline, envOverride *chartConfig.EnvConfigOverride, ctx context.Context) (bool, error) {
func (impl *TriggerServiceImpl) updateArgoPipeline(ctx context.Context, pipeline *pipelineConfig.Pipeline, envOverride *chartConfig.EnvConfigOverride) (bool, error) {
if ctx == nil {
impl.logger.Errorw("err in syncing ACD, ctx is NULL", "pipelineName", pipeline.Name)
return false, nil
}
argoAppName := pipeline.DeploymentAppName
impl.logger.Infow("received payload, updateArgoPipeline", "appId", pipeline.AppId, "pipelineName", pipeline.Name, "envId", envOverride.TargetEnvironment, "argoAppName", argoAppName, "context", ctx)
impl.logger.Infow("received payload, updateArgoPipeline", "appId", pipeline.AppId, "pipelineName", pipeline.Name, "envId", envOverride.TargetEnvironment, "argoAppName", argoAppName)
argoApplication, err := impl.argoClientWrapperService.GetArgoAppByName(ctx, argoAppName)
if err != nil {
impl.logger.Errorw("no argo app exists", "app", argoAppName, "pipeline", pipeline.Name)
Expand Down
14 changes: 8 additions & 6 deletions pkg/eventProcessor/in/WorkflowEventProcessorService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,12 +795,14 @@ func (impl *WorkflowEventProcessorImpl) SubscribeCDPipelineDeleteEvent() error {
impl.logger.Errorw("error in fetching pipeline by pipelineId", "err", err, "pipelineId", cdPipelineDeleteEvent.PipelineId)
return
}
impl.RemoveReleaseContextForPipeline(cdPipelineDeleteEvent)
//there is a possibility that when the pipeline was deleted, async request nats message was not consumed completely and could have led to dangling deployment app
//trying to delete deployment app once
err = impl.cdPipelineConfigService.DeleteHelmTypePipelineDeploymentApp(context.Background(), true, pipeline)
if err != nil {
impl.logger.Errorw("error, DeleteHelmTypePipelineDeploymentApp", "pipelineId", pipeline.Id)
if pipeline.DeploymentAppType == bean5.Helm {
impl.RemoveReleaseContextForPipeline(cdPipelineDeleteEvent)
//there is a possibility that when the pipeline was deleted, async request nats message was not consumed completely and could have led to dangling deployment app
//trying to delete deployment app once
err = impl.cdPipelineConfigService.DeleteHelmTypePipelineDeploymentApp(context.Background(), true, pipeline)
if err != nil {
impl.logger.Errorw("error, DeleteHelmTypePipelineDeploymentApp", "pipelineId", pipeline.Id)
}
}
}
// add required logging here
Expand Down