From 4d73e3f687ae8e201f4e8861c77ce391c73ff2a7 Mon Sep 17 00:00:00 2001 From: ayushmaheshwari Date: Wed, 17 Apr 2024 19:38:38 +0530 Subject: [PATCH 1/2] setting history default value to one --- api/helm-app/service/HelmAppService.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/api/helm-app/service/HelmAppService.go b/api/helm-app/service/HelmAppService.go index f6f19732ce..d68c04da6f 100644 --- a/api/helm-app/service/HelmAppService.go +++ b/api/helm-app/service/HelmAppService.go @@ -119,9 +119,9 @@ func NewHelmAppServiceImpl(Logger *zap.SugaredLogger, clusterService cluster.Clu } type HelmReleaseConfig struct { - RevisionHistoryLimitDevtronApp int `env:"REVISION_HISTORY_LIMIT_DEVTRON_APP" envDefault:"0"` - RevisionHistoryLimitHelmApp int `env:"REVISION_HISTORY_LIMIT_HELM_APP" envDefault:"0"` - RevisionHistoryLimitExternalHelmApp int `env:"REVISION_HISTORY_LIMIT_EXTERNAL_HELM_APP" envDefault:"0"` + RevisionHistoryLimitDevtronApp int `env:"REVISION_HISTORY_LIMIT_DEVTRON_APP" envDefault:"1"` + RevisionHistoryLimitHelmApp int `env:"REVISION_HISTORY_LIMIT_HELM_APP" envDefault:"1"` + RevisionHistoryLimitExternalHelmApp int `env:"REVISION_HISTORY_LIMIT_EXTERNAL_HELM_APP" envDefault:"1"` } func GetHelmReleaseConfig() (*HelmReleaseConfig, error) { From d04dd6833878e92597419ab186b56d5b473a896c Mon Sep 17 00:00:00 2001 From: ayushmaheshwari Date: Wed, 17 Apr 2024 20:17:09 +0530 Subject: [PATCH 2/2] reverting change for external helm apps --- api/helm-app/service/HelmAppService.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/helm-app/service/HelmAppService.go b/api/helm-app/service/HelmAppService.go index d68c04da6f..094b8663f7 100644 --- a/api/helm-app/service/HelmAppService.go +++ b/api/helm-app/service/HelmAppService.go @@ -121,7 +121,7 @@ func NewHelmAppServiceImpl(Logger *zap.SugaredLogger, clusterService cluster.Clu type HelmReleaseConfig struct { RevisionHistoryLimitDevtronApp int `env:"REVISION_HISTORY_LIMIT_DEVTRON_APP" envDefault:"1"` RevisionHistoryLimitHelmApp int `env:"REVISION_HISTORY_LIMIT_HELM_APP" envDefault:"1"` - RevisionHistoryLimitExternalHelmApp int `env:"REVISION_HISTORY_LIMIT_EXTERNAL_HELM_APP" envDefault:"1"` + RevisionHistoryLimitExternalHelmApp int `env:"REVISION_HISTORY_LIMIT_EXTERNAL_HELM_APP" envDefault:"0"` } func GetHelmReleaseConfig() (*HelmReleaseConfig, error) {