fix: update semverCompare kube version with proper Major.Minor.Patch-release placeholders for helm to compare #4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash100198
requested review from
prakarsh-dt,
pawan-mehta-dt and
nishant-d
as code owners
github-actions
bot
added
PR:Issue-verification-failed
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
github-actions
bot
added
PR:Issue-verification-failed
and removed
PR:Ready-to-Review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr addresses the issue where .Capabilities.KubeVersion.GitVersion in case of eks, gke clusters were evaluated to be something like v1.25.16-eks-randomstring (with pre-release tag), but our cronjob/job charts were not having proper patch and pre-release placeholders for helm to compare, hence even though the server version would be > 1.20 (say 1.25) but the semverCompare check was failing because of the failing condition that if serverVersion has pre-release tag and constraint doesn't then helm considers them as incompatible. Hence have updated the condition.
This pr also updates the semverCompare serverVersion parameter to .Capabilities.KubeVersion.Version, instead of Capabilities.KubeVersion.GitVersion , since GitVersion is deprecated.
Fixes #
Checklist:
Does this PR introduce a user-facing change?