From ff7bf8169d7b49b8e89292410e6235ae610ed7a0 Mon Sep 17 00:00:00 2001 From: kartik-579 Date: Wed, 24 Apr 2024 15:07:08 +0530 Subject: [PATCH 1/2] removed redundant import --- env_gen.md | 4 ++-- pkg/variables/ScopedVariableService.go | 11 +++++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/env_gen.md b/env_gen.md index ea8c8de083..7b220f4793 100644 --- a/env_gen.md +++ b/env_gen.md @@ -196,9 +196,9 @@ | REQ_CI_MEM | 3G | | | RESOURCE_LIST_FOR_REPLICAS | Deployment,Rollout,StatefulSet,ReplicaSet | | | RESOURCE_LIST_FOR_REPLICAS_BATCH_SIZE | 5 | | - | REVISION_HISTORY_LIMIT_DEVTRON_APP | 0 | | + | REVISION_HISTORY_LIMIT_DEVTRON_APP | 1 | | | REVISION_HISTORY_LIMIT_EXTERNAL_HELM_APP | 0 | | - | REVISION_HISTORY_LIMIT_HELM_APP | 0 | | + | REVISION_HISTORY_LIMIT_HELM_APP | 1 | | | RUNTIME_CONFIG_LOCAL_DEV | false | | | RUN_HELM_INSTALL_IN_ASYNC_MODE_HELM_APPS | false | | | SCOPED_VARIABLE_ENABLED | false | | diff --git a/pkg/variables/ScopedVariableService.go b/pkg/variables/ScopedVariableService.go index 77e457f66c..eb8bf97a86 100644 --- a/pkg/variables/ScopedVariableService.go +++ b/pkg/variables/ScopedVariableService.go @@ -32,12 +32,11 @@ type ScopedVariableService interface { } type ScopedVariableServiceImpl struct { - logger *zap.SugaredLogger - scopedVariableRepository repository2.ScopedVariableRepository - qualifierMappingService resourceQualifiers.QualifierMappingService - devtronResourceSearchableKeyService devtronResource.DevtronResourceSearchableKeyService - VariableNameConfig *VariableConfig - VariableCache *cache.VariableCacheObj + logger *zap.SugaredLogger + scopedVariableRepository repository2.ScopedVariableRepository + qualifierMappingService resourceQualifiers.QualifierMappingService + VariableNameConfig *VariableConfig + VariableCache *cache.VariableCacheObj } func NewScopedVariableServiceImpl(logger *zap.SugaredLogger, scopedVariableRepository repository2.ScopedVariableRepository, appRepository app.AppRepository, environmentRepository repository.EnvironmentRepository, devtronResourceSearchableKeyService devtronResource.DevtronResourceSearchableKeyService, clusterRepository repository.ClusterRepository, From 9c3dc3494a79a6d9ad3fc029d2eb97498afe0dae Mon Sep 17 00:00:00 2001 From: kartik-579 Date: Wed, 24 Apr 2024 16:28:49 +0530 Subject: [PATCH 2/2] reversed auto changes --- env_gen.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env_gen.md b/env_gen.md index 7b220f4793..ea8c8de083 100644 --- a/env_gen.md +++ b/env_gen.md @@ -196,9 +196,9 @@ | REQ_CI_MEM | 3G | | | RESOURCE_LIST_FOR_REPLICAS | Deployment,Rollout,StatefulSet,ReplicaSet | | | RESOURCE_LIST_FOR_REPLICAS_BATCH_SIZE | 5 | | - | REVISION_HISTORY_LIMIT_DEVTRON_APP | 1 | | + | REVISION_HISTORY_LIMIT_DEVTRON_APP | 0 | | | REVISION_HISTORY_LIMIT_EXTERNAL_HELM_APP | 0 | | - | REVISION_HISTORY_LIMIT_HELM_APP | 1 | | + | REVISION_HISTORY_LIMIT_HELM_APP | 0 | | | RUNTIME_CONFIG_LOCAL_DEV | false | | | RUN_HELM_INSTALL_IN_ASYNC_MODE_HELM_APPS | false | | | SCOPED_VARIABLE_ENABLED | false | |