fix: fatal log removed

api/router/GrafanaRouter.go

@@ -19,7 +19,7 @@ type GrafanaRouterImpl struct {
 	grafanaProxy func(writer http.ResponseWriter, request *http.Request)
 }
 
-func NewGrafanaRouterImpl(logger *zap.SugaredLogger, grafanaCfg *grafana.Config) *GrafanaRouterImpl {
+func NewGrafanaRouterImpl(logger *zap.SugaredLogger, grafanaCfg *grafana.Config) (*GrafanaRouterImpl, error) {
 	client := &http.Client{
 		Transport: &http.Transport{
 			Proxy: http.ProxyFromEnvironment,
@@ -31,12 +31,15 @@ func NewGrafanaRouterImpl(logger *zap.SugaredLogger, grafanaCfg *grafana.Config)
 			ExpectContinueTimeout: 1 * time.Second,
 		},
 	}
-	grafanaProxy := grafana.NewGrafanaHTTPReverseProxy(fmt.Sprintf("http://%s:%s", grafanaCfg.Host, grafanaCfg.Port), client.Transport)
+	grafanaProxy, err := grafana.NewGrafanaHTTPReverseProxy(fmt.Sprintf("http://%s:%s", grafanaCfg.Host, grafanaCfg.Port), client.Transport)
+	if err != nil {
+		return nil, err
+	}
 	router := &GrafanaRouterImpl{
 		grafanaProxy: grafanaProxy,
 		logger:       logger,
 	}
-	return router
+	return router, nil
 }
 
 func (router GrafanaRouterImpl) initGrafanaRouter(grafanaRouter *mux.Router) {

client/argocdServer/connection/Tls.go

@@ -32,7 +32,6 @@ func GetTLS(cert *tls.Certificate) credentials.TransportCredentials {
 	//These certificates are to be read from secret create by argocd
 	//cert, err := tls.X509KeyPair([]byte(TLSCert), []byte(TLSKey))
 	//if err != nil {
-	//	log.Fatal(err)
 	//}
 	certPool := x509.NewCertPool()
 	pemCertBytes, _ := EncodeX509KeyPair(*cert)

client/dashboard/DashboardRouter.go

@@ -20,7 +20,7 @@ type DashboardRouterImpl struct {
 	dashboardProxy func(writer http.ResponseWriter, request *http.Request)
 }
 
-func NewDashboardRouterImpl(logger *zap.SugaredLogger, dashboardCfg *Config) *DashboardRouterImpl {
+func NewDashboardRouterImpl(logger *zap.SugaredLogger, dashboardCfg *Config) (*DashboardRouterImpl, error) {
 	client := &http.Client{
 		Transport: &http.Transport{
 			Proxy: http.ProxyFromEnvironment,
@@ -32,12 +32,15 @@ func NewDashboardRouterImpl(logger *zap.SugaredLogger, dashboardCfg *Config) *Da
 			ExpectContinueTimeout: 1 * time.Second,
 		},
 	}
-	dashboardProxy := proxy.NewDashboardHTTPReverseProxy(fmt.Sprintf("http://%s:%s", dashboardCfg.Host, dashboardCfg.Port), client.Transport)
+	dashboardProxy, err := proxy.NewDashboardHTTPReverseProxy(fmt.Sprintf("http://%s:%s", dashboardCfg.Host, dashboardCfg.Port), client.Transport)
+	if err != nil {
+		return nil, err
+	}
 	router := &DashboardRouterImpl{
 		dashboardProxy: dashboardProxy,
 		logger:         logger,
 	}
-	return router
+	return router, nil
 }
 
 func (router DashboardRouterImpl) InitDashboardRouter(dashboardRouter *mux.Router) {

client/grafana/proxy.go

@@ -7,15 +7,18 @@ import (
 	"net/url"
 )
 
-func NewGrafanaHTTPReverseProxy(serverAddr string, transport http.RoundTripper) func(writer http.ResponseWriter, request *http.Request) {
+func NewGrafanaHTTPReverseProxy(serverAddr string, transport http.RoundTripper) (func(writer http.ResponseWriter, request *http.Request), error) {
 	target, err := url.Parse(serverAddr)
 	if err != nil {
-		log.Fatal(err)
+		log.Println(err)
+		return func(writer http.ResponseWriter, request *http.Request) {
+			http.Error(writer, "error while parsing target url", http.StatusInternalServerError)
+		}, err
 	}
 	proxy := httputil.NewSingleHostReverseProxy(target)
 	proxy.Transport = transport
 
 	return func(w http.ResponseWriter, r *http.Request) {
 		proxy.ServeHTTP(w, r)
-	}
+	}, nil
 }